r77790 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77789‎ | r77790 | r77791 >
Date:10:34, 5 December 2010
Author:dantman
Status:deferred
Tags:
Comment:
Followup r77782, fix two small bugs and change messages to use something more like "login to another user's accocunt" rather than "sudo".
Modified paths:
  • /trunk/extensions/Sudo/SpecialSudo.php (modified) (history)
  • /trunk/extensions/Sudo/Sudo.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Sudo/SpecialSudo.php
@@ -132,11 +132,10 @@
133133 }
134134
135135 function showError( $error ) {
136 - $wgOut->addHTML(
137 - Xml::openElement('div', array( 'class' => 'sudo-error' )).
138 - wfMsgHtml('sudo-error',wfMsg($error)).
139 - Xml::closeElement('div')
140 - );
 136+ global $wgOut;
 137+ $wgOut->addHTML( Xml::openElement('div', array( 'class' => 'sudo-error' )) );
 138+ $wgOut->addWikiText( wfMsg('sudo-error',wfMsg($error)) );
 139+ $wgOut->addHTML( Xml::closeElement('div') );
141140 }
142141
143142 function showErrors() {
Index: trunk/extensions/Sudo/Sudo.i18n.php
@@ -28,17 +28,17 @@
2929 * @author Daniel Friesen
3030 */
3131 $messages['en'] = array(
32 - 'sudo' => 'Sudo',
33 - 'unsudo' => 'Unsudo',
34 - 'sudo-personal-unsudo' => 'unsudo',
35 - 'sudo-form' => 'Sudo into:',
 32+ 'sudo' => "Log into another user's account",
 33+ 'unsudo' => 'Return to your account',
 34+ 'sudo-personal-unsudo' => 'Return to your account',
 35+ 'sudo-form' => 'Login to:',
3636 'sudo-user' => 'Username: ',
3737 'sudo-reason' => 'Reason: ',
38 - 'sudo-submit' => 'sudo',
39 - 'sudo-unsudo' => 'Welcome $1, you are currently sudoed into the wiki as $2, just submit the form to return to your normal login.',
40 - 'sudo-unsudo-submit' => 'unsudo',
41 - 'sudo-success' => 'Welcome $1, you are now sudoed into the wiki as $2.',
42 - 'sudo-error' => 'Could not Sudo: $1',
 38+ 'sudo-submit' => 'Login',
 39+ 'sudo-unsudo' => 'Welcome $1, you are currently logged into the wiki as $2, just submit the form to return to your normal login.',
 40+ 'sudo-unsudo-submit' => 'Return',
 41+ 'sudo-success' => 'Welcome $1, you are now logged into the wiki as $2.',
 42+ 'sudo-error' => 'Sudo Error: $1',
4343 'sudo-error-sudo-invaliduser' => 'Invalid Username',
4444 'sudo-error-sudo-ip' => 'Cannot login to an IP',
4545 'sudo-error-sudo-nonexistant' => 'That user does not exist',
@@ -46,6 +46,6 @@
4747 'sudo-error-nosudo' => 'You do not appear to be inside of a sudo login',
4848 'sudo-logpagename' => 'Sudo log',
4949 'sudo-logpagetext' => 'This is a log of all uses of sudo.',
50 - 'sudo-logentry' => 'sudoed into $2',
 50+ 'sudo-logentry' => "logged into $2's account",
5151 'right-sudo' => "Login to another user's account",
5252 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77782Move my Sudo extension into Wikimedia svn. (committed before fixes to keep ch...dantman08:47, 5 December 2010

Status & tagging log