r77751 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77750‎ | r77751 | r77752 >
Date:23:43, 4 December 2010
Author:aaron
Status:ok
Tags:
Comment:
MFT r77749
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/FlaggedRevs/FRDependencyUpdate.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/FlaggedRevs/FRDependencyUpdate.php
@@ -134,11 +134,11 @@
135135 }
136136 if ( $del ) {
137137 $clause = self::makeWhereFrom2d( $del, wfGetDB( DB_MASTER ) );
138 - $where = array( $clause, 'ftr_from' => $this->title->getArticleId() );
139 - } else {
140 - $where = false;
 138+ if ( $clause ) {
 139+ return array( $clause, 'ftr_from' => $this->title->getArticleId() );
 140+ }
141141 }
142 - return $where;
 142+ return false;
143143 }
144144
145145 // Make WHERE clause to match $arr titles

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77749(bug 26242) SQL error for link tracking can occur in certain cases (all $del ...aaron23:39, 4 December 2010

Status & tagging log