r77739 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77738‎ | r77739 | r77740 >
Date:19:45, 4 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Per Nikerabbit, use array_unshift, as it's more readable than the array_merge of r77733, no need to scap it out though
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionTagView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionTagView.php
@@ -21,7 +21,7 @@
2222 $info = parent::getQueryInfo();
2323 //Don't change table order, see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77733
2424 //Bug in mysql 4 allowed incorrect table ordering joins to work
25 - $info['tables'] = array_merge( array( 'code_tags' ), $info['tables'] );
 25+ array_unshift( $info['tables'], 'code_tags' );
2626 $info['conds'][] = 'cr_repo_id=ct_repo_id';
2727 $info['conds'][] = 'cr_id=ct_rev_id';
2828 $info['conds']['ct_tag'] = $this->mTag; // fixme: normalize input?

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77733Fix table join order bug from change between MySQL 4 to 5.1, noticed by vvv i...reedy18:38, 4 December 2010

Status & tagging log