| Index: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionTagView.php |
| — | — | @@ -19,7 +19,9 @@ |
| 20 | 20 | |
| 21 | 21 | function getQueryInfo() { |
| 22 | 22 | $info = parent::getQueryInfo(); |
| 23 | | - $info['tables'][] = 'code_tags'; |
| | 23 | + //Don't change table order, see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77733 |
| | 24 | + //Bug in mysql 4 allowed incorrect table ordering joins to work |
| | 25 | + $info['tables'] = array_merge( array( 'code_tags' ), $info['tables'] ); |
| 24 | 26 | $info['conds'][] = 'cr_repo_id=ct_repo_id'; |
| 25 | 27 | $info['conds'][] = 'cr_id=ct_rev_id'; |
| 26 | 28 | $info['conds']['ct_tag'] = $this->mTag; // fixme: normalize input? |
| Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionTagView.php |
| ___________________________________________________________________ |
| Added: svn:mergeinfo |
| 27 | 29 | Merged /trunk/extensions/CodeReview/ui/CodeRevisionTagView.php:r62838-74821,74985,75235,75559,77698,77700,77704,77707,77733-77734 |
| 28 | 30 | Merged /trunk/phase3/extensions/CodeReview/ui/CodeRevisionTagView.php:r77555,77558-77560,77563-77565,77573 |