r77734 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77733‎ | r77734 | r77735 >
Date:18:43, 4 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Useful comment to go with r77733
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionTagView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionTagView.php
@@ -19,6 +19,8 @@
2020
2121 function getQueryInfo() {
2222 $info = parent::getQueryInfo();
 23+ //Don't change table order, see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77733
 24+ //Bug in mysql 4 allowed incorrect table ordering joins to work
2325 $info['tables'] = array_merge( array( 'code_tags' ), $info['tables'] );
2426 $info['conds'][] = 'cr_repo_id=ct_repo_id';
2527 $info['conds'][] = 'cr_id=ct_rev_id';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77733Fix table join order bug from change between MySQL 4 to 5.1, noticed by vvv i...reedy18:38, 4 December 2010

Status & tagging log