r77661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77660‎ | r77661 | r77662 >
Date:14:47, 3 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Add array_unique to SvnRevTablePager->getSelectFields() to save dupe cr_id
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -279,15 +279,17 @@
280280 }
281281
282282 function getSelectFields() {
283 - return array( $this->getDefaultSort(),
284 - 'cr_id',
285 - 'cr_repo_id',
286 - 'cr_status',
287 - 'COUNT(DISTINCT cc_id) AS comments',
288 - 'cr_path',
289 - 'cr_message',
290 - 'cr_author',
291 - 'cr_timestamp' );
 283+ return array_unique(
 284+ array( $this->getDefaultSort(),
 285+ 'cr_id',
 286+ 'cr_repo_id',
 287+ 'cr_status',
 288+ 'COUNT(DISTINCT cc_id) AS comments',
 289+ 'cr_path',
 290+ 'cr_message',
 291+ 'cr_author',
 292+ 'cr_timestamp'
 293+ ) );
292294 }
293295
294296 function getFieldNames() {

Status & tagging log