r77636 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77635‎ | r77636 | r77637 >
Date:09:40, 3 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Per MaxSem CR on r77597, make $alias paramater optional, as per the documentation
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -1581,7 +1581,7 @@
15821582 * @param $alias string Alias (optional)
15831583 * @return string SQL name for aliased table. Will not alias a table to its own name
15841584 */
1585 - public function tableNameWithAlias( $name, $alias ) {
 1585+ public function tableNameWithAlias( $name, $alias = false ) {
15861586 if ( !$alias || $alias == $name ) {
15871587 return $this->tableName( $name );
15881588 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77597Per Roans request, Merge in r65475 (Database.php only) from querypage-work2 b...reedy19:39, 2 December 2010

Status & tagging log