r77596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77595‎ | r77596 | r77597 >
Date:19:35, 2 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
Add some whitespace
Modified paths:
  • /branches/querypage-work2/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: branches/querypage-work2/phase3/includes/db/Database.php
@@ -1619,24 +1619,24 @@
16201620 $alias = $table;
16211621 }
16221622 // Is there a JOIN and INDEX clause for this table?
1623 - if ( isset($join_conds_safe[$alias]) && isset($use_index_safe[$alias]) ) {
 1623+ if ( isset( $join_conds_safe[$alias] ) && isset( $use_index_safe[$alias] ) ) {
16241624 $tableClause = $join_conds_safe[$alias][0] . ' ' . $this->tableNameWithAlias( $table, $alias );
16251625 $tableClause .= ' ' . $this->useIndexClause( implode( ',', (array)$use_index_safe[$alias] ) );
1626 - $on = $this->makeList((array)$join_conds_safe[$alias][1], LIST_AND);
 1626+ $on = $this->makeList( (array)$join_conds_safe[$alias][1], LIST_AND );
16271627 if ( $on != '' ) {
16281628 $tableClause .= ' ON (' . $on . ')';
16291629 }
16301630
16311631 $retJOIN[] = $tableClause;
16321632 // Is there an INDEX clause?
1633 - } else if ( isset($use_index_safe[$alias]) ) {
 1633+ } else if ( isset( $use_index_safe[$alias] ) ) {
16341634 $tableClause = $this->tableNameWithAlias( $table, $alias );
16351635 $tableClause .= ' ' . $this->useIndexClause( implode( ',', (array)$use_index_safe[$alias] ) );
16361636 $ret[] = $tableClause;
16371637 // Is there a JOIN clause?
1638 - } else if ( isset($join_conds_safe[$alias]) ) {
 1638+ } else if ( isset( $join_conds_safe[$alias] ) ) {
16391639 $tableClause = $join_conds_safe[$alias][0] . ' ' . $this->tableNameWithAlias( $table, $alias );
1640 - $on = $this->makeList((array)$join_conds_safe[$alias][1], LIST_AND);
 1640+ $on = $this->makeList( (array)$join_conds_safe[$alias][1], LIST_AND );
16411641 if ( $on != '' ) {
16421642 $tableClause .= ' ON (' . $on . ')';
16431643 }

Status & tagging log