r77578 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77577‎ | r77578 | r77579 >
Date:15:36, 2 December 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Small change to KML printer
Modified paths:
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/includes/Maps_KMLFormatter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.php
@@ -36,7 +36,7 @@
3737 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3838 }
3939 else {
40 - define( 'Maps_VERSION', '0.7.3' );
 40+ define( 'Maps_VERSION', '0.7.4 alpha' );
4141
4242 // The different coordinate notations.
4343 define( 'Maps_COORDS_FLOAT', 'float' );
Index: trunk/extensions/Maps/includes/Maps_KMLFormatter.php
@@ -13,13 +13,28 @@
1414 class MapsKMLFormatter {
1515
1616 /**
 17+ * @since 0.7.4
 18+ *
 19+ * @var array
 20+ */
 21+ protected $params;
 22+
 23+ /**
1724 * @since 0.7.3
1825 *
1926 * @var array of MapsLocation
2027 */
2128 protected $placemarks;
2229
23 - public function __construct() {
 30+ /**
 31+ * Constructor.
 32+ *
 33+ * @since 0.7.3
 34+ *
 35+ * @param array $params
 36+ */
 37+ public function __construct( array $params = array() ) {
 38+ $this->params = $params;
2439 $this->clearElements();
2540 }
2641
@@ -152,4 +167,4 @@
153168 EOT;
154169 }
155170
156 -}
\ No newline at end of file
 171+}

Status & tagging log