r77548 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77547‎ | r77548 | r77549 >
Date:23:08, 1 December 2010
Author:tparscal
Status:deferred
Tags:
Comment:
Moved the tabs back over to the left side
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-break.png (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-fade.png (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-fade.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/images/tab-break.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.css
@@ -11,7 +11,7 @@
1212 height: 13.5em;
1313 background-color: #f3f3f3;
1414 border: 1px solid #cccccc;
15 - border-right: none;
 15+ border-left: none;
1616 padding-bottom: 1px;
1717 }
1818
@@ -23,7 +23,7 @@
2424 width: 8em;
2525 height: 13.5em;
2626 background-image: url(images/tab-break.png);
27 - background-position: left top;
 27+ background-position: right top;
2828 background-repeat: repeat-y;
2929 padding-bottom: 3px;
3030 }
@@ -36,7 +36,7 @@
3737 cursor: pointer;
3838 background-color: #ffffff;
3939 background-image: url(images/tab-edge.png);
40 - background-position: left top;
 40+ background-position: right top;
4141 background-repeat: repeat-y;
4242 }
4343
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback-beta/ext.articleFeedback-beta.js
@@ -2,74 +2,6 @@
33 * Script for Article Feedback (beta)
44 */
55
6 -/*
7 - * This is the desired output...
8 - *
9 -<div class="articleFeedback">
10 - <div class="articleFeedback-panel" rel="form">
11 - <div class="articleFeedback-buffer">
12 - <div class="articleFeedback-title"></div>
13 - <div class="articleFeedback-instructions"></div>
14 - <div style="clear:both;"></div>
15 - <table>
16 - <tr>
17 - <td><div class="articleFeedback-label" rel="wellsourced"></div></td>
18 - <td><div class="articleFeedback-control" rel="wellsourced"></div></td>
19 - <td><div class="articleFeedback-label" rel="complete"></div></td>
20 - <td><div class="articleFeedback-control" rel="complete"></div></td>
21 - </tr>
22 - <tr>
23 - <td><div class="articleFeedback-label" rel="neutral"></div></td>
24 - <td><div class="articleFeedback-control" rel="neutral"></div></td>
25 - <td><div class="articleFeedback-label" rel="readable"></div></td>
26 - <td><div class="articleFeedback-control" rel="readable"></div></td>
27 - </tr>
28 - </table>
29 - <hr noshade size="1" />
30 - <div class="articleFeedback-notice"></div>
31 - <div class="articleFeedback-submit"><button type="button"></button></div>
32 - <div style="clear:both;"></div>
33 - </div>
34 - </div>
35 - <div class="articleFeedback-tabs">
36 - <div class="articleFeedback-tab" rel="form">
37 - <div class="articleFeedback-buffer"></div>
38 - </div>
39 - <div class="articleFeedback-tab" rel="chart">
40 - <div class="articleFeedback-buffer"></div>
41 - </div>
42 - </div>
43 - <div class="articleFeedback-panel" rel="report">
44 - <div class="articleFeedback-buffer">
45 - <div class="articleFeedback-title"></div>
46 - <div style="clear:both;"></div>
47 - <table>
48 - <tr>
49 - <td><div class="articleFeedback-label" rel="wellsourced"></div></td>
50 - <td><div class="articleFeedback-chart" rel="wellsourced"></div></td>
51 - <td><div class="articleFeedback-count" rel="wellsourced"></div></td>
52 - </tr>
53 - <tr>
54 - <td><div class="articleFeedback-label" rel="complete"></div></td>
55 - <td><div class="articleFeedback-chart" rel="complete"></div></td>
56 - <td><div class="articleFeedback-count" rel="complete"></div></td>
57 - </tr>
58 - <tr>
59 - <td><div class="articleFeedback-label" rel="neutral"></div></td>
60 - <td><div class="articleFeedback-chart" rel="neutral"></div></td>
61 - <td><div class="articleFeedback-count" rel="neutral"></div></td>
62 - </tr>
63 - <tr>
64 - <td><div class="articleFeedback-label" rel="readable"></div></td>
65 - <td><div class="articleFeedback-chart" rel="readable"></div></td>
66 - <td><div class="articleFeedback-count" rel="readable"></div></td>
67 - </tr>
68 - </table>
69 - </div>
70 - </div>
71 -</div>
72 -*/
73 -
746 ( function( $, mw ) {
757
768 $.articleFeedback = {
@@ -82,12 +14,6 @@
8315 context.$ui
8416 .addClass( 'articleFeedback articleFeedback-form' )
8517 .append( '\
86 - <div class="articleFeedback-panel" rel="form">\
87 - <div class="articleFeedback-buffer"></div>\
88 - </div>\
89 - <div class="articleFeedback-panel" rel="report">\
90 - <div class="articleFeedback-buffer"></div>\
91 - </div>\
9218 <div class="articleFeedback-tabs">\
9319 <div class="articleFeedback-tab articleFeedback-tab-current" rel="form">\
9420 <div class="articleFeedback-buffer"></div>\
@@ -96,6 +22,12 @@
9723 <div class="articleFeedback-buffer"></div>\
9824 </div>\
9925 </div>\
 26+ <div class="articleFeedback-panel" rel="form">\
 27+ <div class="articleFeedback-buffer"></div>\
 28+ </div>\
 29+ <div class="articleFeedback-panel" rel="report">\
 30+ <div class="articleFeedback-buffer"></div>\
 31+ </div>\
10032 ' )
10133 // Handles
10234 .find( '.articleFeedback-tab' )

Status & tagging log