r77499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77498‎ | r77499 | r77500 >
Date:19:06, 30 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Few braces and spaces

Fixing up documentation
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/PageQueryPage.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)
  • /trunk/phase3/includes/memcached-client.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -23,11 +23,13 @@
2424 $diff = $wgRequest->getVal( 'diff' );
2525 $diffOnly = $wgRequest->getBool( 'diffonly', $wgUser->getOption( 'diffonly' ) );
2626
27 - if ( isset( $diff ) && $diffOnly )
 27+ if ( isset( $diff ) && $diffOnly ) {
2828 return parent::view();
 29+ }
2930
30 - if ( !wfRunHooks( 'CategoryPageView', array( &$this ) ) )
 31+ if ( !wfRunHooks( 'CategoryPageView', array( &$this ) ) ) {
3132 return;
 33+ }
3234
3335 if ( NS_CATEGORY == $this->mTitle->getNamespace() ) {
3436 $this->openShowCategory();
Index: trunk/phase3/includes/User.php
@@ -3207,7 +3207,7 @@
32083208 * Return the set of defined explicit groups.
32093209 * The implicit groups (by default *, 'user' and 'autoconfirmed')
32103210 * are not included, as they are defined automatically, not in the database.
3211 - * @return \type{\arrayof{\string}} Array of internal group names
 3211+ * @return Array of internal group names
32123212 */
32133213 static function getAllGroups() {
32143214 global $wgGroupPermissions, $wgRevokePermissions;
@@ -3219,7 +3219,7 @@
32203220
32213221 /**
32223222 * Get a list of all available permissions.
3223 - * @return \type{\arrayof{\string}} Array of permission names
 3223+ * @return Array of permission names
32243224 */
32253225 static function getAllRights() {
32263226 if ( self::$mAllRights === false ) {
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -3206,7 +3206,7 @@
32073207 /**
32083208 * Get an object referring to a locally registered file.
32093209 * Returns a valid placeholder object if the file does not exist.
3210 - * @param $title Either a string or Title object
 3210+ * @param $title Title|String
32113211 * @return File, or null if passed an invalid Title
32123212 */
32133213 function wfLocalFile( $title ) {
Index: trunk/phase3/includes/db/Database.php
@@ -604,7 +604,7 @@
605605 * comment (you can use __METHOD__ or add some extra info)
606606 * @param $tempIgnore Boolean: Whether to avoid throwing an exception on errors...
607607 * maybe best to catch the exception instead?
608 - * @return true for a successful write query, ResultWrapper object for a successful read query,
 608+ * @return boolean|ResultWrapper true for a successful write query, ResultWrapper object for a successful read query,
609609 * or false on failure if $tempIgnore set
610610 * @throws DBQueryError Thrown when the database returns an error of any kind
611611 */
Index: trunk/phase3/includes/PageQueryPage.php
@@ -18,8 +18,9 @@
1919 global $wgContLang;
2020 $title = Title::makeTitleSafe( $row->namespace, $row->title );
2121 $text = $row->title;
22 - if ($title instanceof Title)
23 - $text = $wgContLang->convert( $title->getPrefixedText() );
24 - return $skin->link( $title, htmlspecialchars($text), array(), array(), array('known', 'noclasses') );
 22+ if ( $title instanceof Title ) {
 23+ $text = $wgContLang->convert( $title->getPrefixedText() );
 24+ }
 25+ return $skin->link( $title, htmlspecialchars( $text ), array(), array(), array('known', 'noclasses') );
2526 }
2627 }
Index: trunk/phase3/includes/memcached-client.php
@@ -240,7 +240,7 @@
241241 /**
242242 * Memcache initializer
243243 *
244 - * @param $args Associative array of settings
 244+ * @param $args Array Associative array of settings
245245 *
246246 * @return mixed
247247 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r77595pipe does not look nice in doxygen. fu r77499hashar19:33, 2 December 2010

Status & tagging log