r77494 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77493‎ | r77494 | r77495 >
Date:18:37, 30 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Assignment to $messages ($message = $this->escapeForScript($message);) seemed wrong
Modified paths:
  • /trunk/phase3/includes/MessageCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MessageCache.php
@@ -174,9 +174,9 @@
175175
176176 fwrite($file,"<?php\n//$hash\n\n \$this->mCache = array(");
177177
178 - foreach ($array as $key => $message) {
 178+ foreach ( $array as $key => $message ) {
179179 $key = $this->escapeForScript($key);
180 - $messages = $this->escapeForScript($message);
 180+ $message = $this->escapeForScript($message);
181181 fwrite($file, "'$key' => '$message',\n");
182182 }
183183

Status & tagging log