r77488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77487‎ | r77488 | r77489 >
Date:18:24, 30 November 2010
Author:platonides
Status:ok
Tags:
Comment:
Document a bit what's going on and get rid of a warning.
Modified paths:
  • /trunk/phase3/includes/installer/OracleInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/OracleInstaller.php
@@ -174,9 +174,12 @@
175175 }
176176
177177 if ( !$this->db->selectDB( $this->getVar( 'wgDBuser' ) ) ) {
178 - global $_OracleDefTS, $_OracleTempTS;
179 - $_OracleDefTS = $this->getVar( '_OracleDefTS' );
180 - $_OracleTempTS = $this->getVar( '_OracleTempTS' );
 178+ /**
 179+ * The variables $_OracleDefTS, $_OracleTempTS are used by maintenance/oracle/user.sql
 180+ * Set here for fetching in DatabaseOracle::replaceVars()
 181+ */
 182+ $GLOBALS['_OracleDefTS'] = $this->getVar( '_OracleDefTS' );
 183+ $GLOBALS['_OracleTempTS'] = $this->getVar( '_OracleTempTS' );
181184 $error = $this->db->sourceFile( "$IP/maintenance/oracle/user.sql" );
182185 if ( $error !== true || !$this->db->selectDB( $this->getVar( 'wgDBuser' ) ) ) {
183186 $status->fatal( 'config-install-user-failed', $this->getVar( 'wgDBuser' ), $error );

Status & tagging log