r77482 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77481‎ | r77482 | r77483 >
Date:15:30, 30 November 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Version 0.7.3.
Modified paths:
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_QueryHandler.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -443,8 +443,7 @@
444444 }
445445 } // Icon can be set even for regular, non-compound queries If it is, though, we have to translate the name into a URL here
446446 elseif ( $this->icon != '' ) {
447 - $icon_image_page = new ImagePage( Title::newFromText( $this->icon ) );
448 - $icon = $icon_image_page->getDisplayedFile()->getURL();
 447+ $icon = MapsMapper::getImageUrl( $this->icon );
449448 }
450449
451450 return $icon;
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_QueryHandler.php
@@ -231,8 +231,7 @@
232232 }
233233 } // Icon can be set even for regular, non-compound queries If it is, though, we have to translate the name into a URL here
234234 elseif ( $this->icon != '' ) {
235 - $icon_image_page = new ImagePage( Title::newFromText( $this->icon ) );
236 - $icon = $icon_image_page->getDisplayedFile()->getURL();
 235+ $icon = MapsMapper::getImageUrl( $this->icon );
237236 }
238237
239238 return $icon;
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -38,7 +38,7 @@
3939
4040 // Only initialize the extension when all dependencies are present.
4141 if ( defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' ) ) {
42 - define( 'SM_VERSION', '0.7.3 beta 1' );
 42+ define( 'SM_VERSION', '0.7.3' );
4343
4444 $useExtensionPath = version_compare( $wgVersion, '1.16', '>=' ) && isset( $wgExtensionAssetsPath ) && $wgExtensionAssetsPath;
4545 $smgScriptPath = ( $useExtensionPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions' ) . '/SemanticMaps';

Status & tagging log