r77431 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77430‎ | r77431 | r77432 >
Date:19:53, 29 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r77405 , based on Code Review - removed extraneous calls to Database::tableNames()
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -200,7 +200,7 @@
201201 */
202202 static function getAllForms() {
203203 $dbr = wfGetDB( DB_SLAVE );
204 - $res = $dbr->select( $dbr->tableNames( 'page' ),
 204+ $res = $dbr->select( 'page',
205205 'page_title',
206206 array( 'page_namespace' => SF_NS_FORM,
207207 'page_is_redirect' => false ),
@@ -373,7 +373,7 @@
374374 $substring = str_replace( "'", "\'", $substring );
375375 $conditions .= " AND (LOWER(CONVERT(`page_title` USING utf8)) LIKE '$substring%' OR LOWER(CONVERT(`page_title` USING utf8)) LIKE '%\_$substring%')";
376376 }
377 - $res = $db->select( $db->tableNames( 'page' ),
 377+ $res = $db->select( 'page',
378378 'page_title',
379379 $conditions, __METHOD__,
380380 array( 'ORDER BY' => 'page_title' ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77405Improved SQL querying callsyaron22:29, 28 November 2010

Status & tagging log