| Index: trunk/extensions/CodeReview/backend/CodeRevision.php |
| — | — | @@ -667,7 +667,6 @@ |
| 668 | 668 | * @param $revs array of revision IDs |
| 669 | 669 | */ |
| 670 | 670 | public function addReferencesTo( $revs ) { |
| 671 | | - // TODO: Refactor common bits out |
| 672 | 671 | $dbw = wfGetDB( DB_MASTER ); |
| 673 | 672 | $data = array(); |
| 674 | 673 | foreach ( array_unique( (array)$revs ) as $rev ) { |
| — | — | @@ -688,7 +687,6 @@ |
| 689 | 688 | * @param $revs array of revision IDs |
| 690 | 689 | */ |
| 691 | 690 | public function removeReferencesFrom( $revs ) { |
| 692 | | - // TODO: Introduce removeReferencesTo() and refactor common bits out |
| 693 | 691 | $dbw = wfGetDB( DB_MASTER ); |
| 694 | 692 | $dbw->delete( 'code_relations', array( |
| 695 | 693 | 'cf_repo_id' => $this->getRepoId(), |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php |
| — | — | @@ -2,10 +2,8 @@ |
| 3 | 3 | |
| 4 | 4 | // Special:Code/MediaWiki |
| 5 | 5 | class CodeRevisionListView extends CodeView { |
| 6 | | - public $mRepo, $mPath; |
| | 6 | + public $mRepo, $mPath, $batchForm; |
| 7 | 7 | |
| 8 | | - private $batchForm; |
| 9 | | - |
| 10 | 8 | function __construct( $repoName ) { |
| 11 | 9 | global $wgRequest; |
| 12 | 10 | parent::__construct(); |
| — | — | @@ -298,7 +296,7 @@ |
| 299 | 297 | 'cr_timestamp' => wfMsg( 'code-field-timestamp' ), |
| 300 | 298 | ); |
| 301 | 299 | # Only show checkboxen as needed |
| 302 | | - if ( !empty( $this->mView->batchForm ) ) { |
| | 300 | + if ( $this->mView->batchForm ) { |
| 303 | 301 | $fields = array( 'selectforchange' => wfMsg( 'code-field-select' ) ) + $fields; |
| 304 | 302 | } |
| 305 | 303 | return $fields; |