r77420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77419‎ | r77420 | r77421 >
Date:08:44, 29 November 2010
Author:reedy
Status:deferred
Tags:
Comment:
Few bits of indending and line wrapping
Modified paths:
  • /trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php
@@ -86,17 +86,17 @@
8787
8888 if ( 'sitemap' == $this->params['feed'] ) {
8989 $feed = new SitemapFeed(
90 - $wgServer . $wgScriptPath,
91 - date( DATE_ATOM )
 90+ $wgServer . $wgScriptPath,
 91+ date( DATE_ATOM )
9292 );
9393 } else {
9494 // FIXME: These should be configurable at some point
9595 $feed = new $wgFeedClasses[ $this->params['feed'] ](
96 - $wgSitename,
97 - $wgSitename . ' ' . $this->params['feed'] . ' feed',
98 - $wgServer . $wgScriptPath,
99 - date( DATE_ATOM ),
100 - $wgSitename
 96+ $wgSitename,
 97+ $wgSitename . ' ' . $this->params['feed'] . ' feed',
 98+ $wgServer . $wgScriptPath,
 99+ date( DATE_ATOM ),
 100+ $wgSitename
101101 );
102102 }
103103
@@ -147,14 +147,17 @@
148148 $talkpage = $title->getTalkPage();
149149 $comments = $talkpage->getFullURL();
150150 }
151 - $titleText = ( true === $this->params['nameSpace'] ) ? $title->getPrefixedText() : $title->getText();
 151+ $titleText = ( true === $this->params['nameSpace'] )
 152+ ? $title->getPrefixedText()
 153+ : $title->getText();
152154 $feedItem = new FeedItem(
153 - $titleText,
154 - $this->feedItemDesc( $row ),
155 - $title->getFullURL(),
156 - $this->Date,
157 - $this->feedItemAuthor( $row ),
158 - $comments );
 155+ $titleText,
 156+ $this->feedItemDesc( $row ),
 157+ $title->getFullURL(),
 158+ $this->Date,
 159+ $this->feedItemAuthor( $row ),
 160+ $comments
 161+ );
159162 }
160163 $feed->outItem( $feedItem );
161164 }
@@ -168,7 +171,8 @@
169172 **/
170173 public function dpl_buildSQL() {
171174 $dbr = wfGetDB( DB_SLAVE );
172 - $sqlSelectFrom = 'SELECT page_namespace, page_title, page_id, c1.cl_timestamp FROM ' . $dbr->tableName( 'page' );
 175+ $sqlSelectFrom = 'SELECT page_namespace, page_title, page_id, c1.cl_timestamp FROM '
 176+ . $dbr->tableName( 'page' );
173177
174178 if ( $this->params['nameSpace'] ) {
175179 $sqlWhere = ' WHERE page_namespace=' . $this->params['iNameSpace'] . ' ';
@@ -434,7 +438,8 @@
435439 $this->params['notCatCount'] = count( $this->notCategories );
436440 $totalCatCount = $this->params['catCount'] + $this->params['notCatCount'];
437441
438 - if ( ( $this->params['catCount'] < 1 && false == $this->params['nameSpace'] ) || ( $totalCatCount < $this->wgDPlminCategories ) ) {
 442+ if ( ( $this->params['catCount'] < 1 && false == $this->params['nameSpace'] )
 443+ || ( $totalCatCount < $this->wgDPlminCategories ) ) {
439444 // echo "Boom on catCount\n";
440445 $parser = new Parser;
441446 $poptions = new ParserOptions;

Status & tagging log