r77417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77416‎ | r77417 | r77418 >
Date:03:29, 29 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Validation function for comboboxes changed from validate_mandatory_combobox() to validate_mandatory_field()
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -991,8 +991,6 @@
992992 if ( empty( $default_value ) ) {
993993 $sfgJSValidationCalls[] = "validate_mandatory_radiobutton('$input_id', '$info_id')";
994994 }
995 - } elseif ( $input_type == 'combobox' ) {
996 - $sfgJSValidationCalls[] = "validate_mandatory_combobox('$input_id', '$info_id')";
997995 } elseif ( ( $form_field->template_field->is_list && $form_field->template_field->field_type == 'enumeration' && $input_type != 'listbox' ) || ( $input_type == 'checkboxes' ) ) {
998996 $sfgJSValidationCalls[] = "validate_mandatory_checkboxes('$input_id', '$info_id')";
999997 } else {

Status & tagging log