r77397 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77396‎ | r77397 | r77398 >
Date:17:02, 28 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Removed Xml::escapeJsString() calls from around setting of global JS variables - seems to cause double-escaping
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
——@@ -26,13 +26,13 @@
2727 $vars['sfgAutocompleteDataTypes'] = (object)$sfgAutocompleteDataTypes;
2828 $vars['sfgComboBoxInputs'] = $sfgComboBoxInputs;
2929 $vars['sfgAutogrowInputs'] = $sfgAutogrowInputs;
30 - $vars['sfgFormErrorsHeader'] = Xml::escapeJsString( wfMsg( 'sf_formerrors_header' ) );
31 - $vars['sfgBlankErrorStr'] = Xml::escapeJsString( wfMsg( 'sf_blank_error' ) );
32 - $vars['sfgBadURLErrorStr'] = Xml::escapeJsString( wfMsg( 'sf_bad_url_error' ) );
33 - $vars['sfgBadEmailErrorStr'] = Xml::escapeJsString( wfMsg( 'sf_bad_email_error' ) );
34 - $vars['sfgBadNumberErrorStr'] = Xml::escapeJsString( wfMsg( 'sf_bad_number_error' ) );
35 - $vars['sfgBadIntegerErrorStr'] = Xml::escapeJsString( wfMsg( 'sf_bad_integer_error' ) );
36 - $vars['sfgBadDateErrorStr'] = Xml::escapeJsString( wfMsg( 'sf_bad_date_error' ) );
 30+ $vars['sfgFormErrorsHeader'] = wfMsg( 'sf_formerrors_header' );
 31+ $vars['sfgBlankErrorStr'] = wfMsg( 'sf_blank_error' );
 32+ $vars['sfgBadURLErrorStr'] = wfMsg( 'sf_bad_url_error' );
 33+ $vars['sfgBadEmailErrorStr'] = wfMsg( 'sf_bad_email_error' );
 34+ $vars['sfgBadNumberErrorStr'] = wfMsg( 'sf_bad_number_error' );
 35+ $vars['sfgBadIntegerErrorStr'] = wfMsg( 'sf_bad_integer_error' );
 36+ $vars['sfgBadDateErrorStr'] = wfMsg( 'sf_bad_date_error' );
3737 $vars['sfgJSValidationCalls'] = $sfgJSValidationCalls;
3838 $vars['sfgShowOnSelectCalls'] = $sfgShowOnSelectCalls;
3939 return true;

Status & tagging log