r77391 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77390‎ | r77391 | r77392 >
Date:16:04, 28 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Fix 1 deprecated method call in SpecialPage, and 3 non static methods called statically
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadStash.php
@@ -308,7 +308,7 @@
309309 * @return String: URL to access thumbnail, or URL with partial path
310310 */
311311 public function getThumbUrl( $thumbName = false ) {
312 - return self::getSpecialUrl( $thumbName );
 312+ return $this->getSpecialUrl( $thumbName );
313313 }
314314
315315 /**
@@ -332,7 +332,7 @@
333333 */
334334 public function getUrl() {
335335 if ( !isset( $this->url ) ) {
336 - $this->url = self::getSpecialUrl( $this->getUrlName() );
 336+ $this->url = $this->getSpecialUrl( $this->getUrlName() );
337337 }
338338 return $this->url;
339339 }
Index: trunk/phase3/includes/parser/Parser.php
@@ -354,7 +354,7 @@
355355 $uniq_prefix = $this->mUniqPrefix;
356356 $matches = array();
357357 $elements = array_keys( $this->mTransparentTagHooks );
358 - $text = self::extractTagsAndParams( $elements, $text, $matches, $uniq_prefix );
 358+ $text = $this->extractTagsAndParams( $elements, $text, $matches, $uniq_prefix );
359359
360360 foreach ( $matches as $marker => $data ) {
361361 list( $element, $content, $params, $tag ) = $data;
Index: trunk/phase3/includes/SpecialPage.php
@@ -573,7 +573,7 @@
574574 $page->including( $including );
575575
576576 // Execute special page
577 - $profName = 'Special:' . $page->getName();
 577+ $profName = 'Special:' . $page->name();
578578 wfProfileIn( $profName );
579579 $page->execute( $par );
580580 wfProfileOut( $profName );

Status & tagging log