r77306 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77305‎ | r77306 | r77307 >
Date:22:35, 25 November 2010
Author:catrope
Status:ok
Tags:
Comment:
Followup r77302: show signoff section even if there are no signoff, so people can actually create a signoff :) The strike signoffs button probably shouldn't show in this case, but I'll deal with that later
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -131,11 +131,8 @@
132132 $html .= $this->formatImgDiff();
133133 }
134134 # Show sign-offs
135 - $signoffs = $this->formatSignoffs( $this->canSignoff() );
136 - if ( $signoffs ) {
137 - $html .= "<h2 id='code-signoffs'>" . wfMsgHtml( 'code-signoffs' ) .
138 - "</h2>\n" . $signoffs;
139 - }
 135+ $html .= "<h2 id='code-signoffs'>" . wfMsgHtml( 'code-signoffs' ) .
 136+ "</h2>\n" . $this->formatSignoffs( $this->canSignoff() );
140137 # Show code relations
141138 $relations = $this->formatReferences();
142139 if ( $relations ) {
@@ -434,9 +431,6 @@
435432 $signoffs = implode( "\n",
436433 array_map( array( $this, 'formatSignoffInline' ), $this->mRev->getSignoffs() )
437434 );
438 - if ( !$signoffs ) {
439 - return false;
440 - }
441435 $header = '<th></th>';
442436 $header .= '<th>' . wfMsg( 'code-signoff-field-user' ) . '</th>';
443437 $header .= '<th>' . wfMsg( 'code-signoff-field-flag' ). '</th>';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77302(bug 26014) Allow users to strike their own sign-offs. Implemented with a tim...catrope21:39, 25 November 2010

Status & tagging log