r77290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77289‎ | r77290 | r77291 >
Date:15:12, 25 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r76419 - override "ignore invisible divs" feature for now, since it ignores even divs we don't want to ignore
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SemanticForms.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SemanticForms.js
@@ -268,7 +268,12 @@
269269 }
270270
271271 function existsAndVisible(field) {
272 - return (field && field.offsetWidth);
 272+ // there's a major bug in the current implementation, which is that
 273+ // it ignores fields hidden by the Header Tabs extension and others -
 274+ // for now, we'll just override the attempted smartness and say that
 275+ // everything is visible.
 276+ return true;
 277+ //return (field && field.offsetWidth);
273278 }
274279
275280 function validate_mandatory_field(field_id, info_id) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76419Added handling for inputs rendered invisible by "show on select", so they don...yaron00:14, 10 November 2010

Status & tagging log