r77288 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77287‎ | r77288 | r77289 >
Date:14:50, 25 November 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 26042) Database error when submitting duplicate sign-off
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
——@@ -685,7 +685,7 @@
686686 'cs_timestamp' => $dbw->timestamp(),
687687 );
688688 }
689 - $dbw->insert( 'code_signoffs', $rows, __METHOD__ );
 689+ $dbw->insert( 'code_signoffs', $rows, __METHOD__, array( 'IGNORE' ) );
690690 }
691691
692692 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r77289Revert r77193: this seems to have intended to fix bug 26042, but r77288 handl...catrope14:59, 25 November 2010

Comments

#Comment by Hashar (talk | contribs)   15:43, 25 November 2010

Much better. I am not sure why I started writing r77193 8-)

Status & tagging log