r77273 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77272‎ | r77273 | r77274 >
Date:08:25, 25 November 2010
Author:raymond
Status:ok
Tags:
Comment:
Remove redundant link 'Existing blocks for $1' because the blog log is shown since r16287
And in case the user is already blocked the message "$1 is already blocked. Do you want to change the settings?" is shown
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2012,7 +2012,6 @@
20132013 'ipb-edit-dropdown',
20142014 'ipb-unblock-addr',
20152015 'ipb-unblock',
2016 - 'ipb-blocklist-addr',
20172016 'ipb-blocklist',
20182017 'ipb-blocklist-contribs',
20192018 'unblockip',
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -811,22 +811,9 @@
812812 * @return string
813813 */
814814 private function getBlockListLink( $skin ) {
815 - $list = SpecialPage::getTitleFor( 'Ipblocklist' );
816 - $query = array();
817 -
818 - if( $this->BlockAddress ) {
819 - $addr = strtr( $this->BlockAddress, '_', ' ' );
820 - $message = wfMsg( 'ipb-blocklist-addr', $addr );
821 - $query['ip'] = $this->BlockAddress;
822 - } else {
823 - $message = wfMsg( 'ipb-blocklist' );
824 - }
825 -
826815 return $skin->linkKnown(
827 - $list,
828 - htmlspecialchars( $message ),
829 - array(),
830 - $query
 816+ SpecialPage::getTitleFor( 'Ipblocklist' ),
 817+ wfMsg( 'ipb-blocklist' )
831818 );
832819 }
833820
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3000,7 +3000,6 @@
30013001 'ipb-edit-dropdown' => 'Edit block reasons',
30023002 'ipb-unblock-addr' => 'Unblock $1',
30033003 'ipb-unblock' => 'Unblock a username or IP address',
3004 -'ipb-blocklist-addr' => 'Existing blocks for $1',
30053004 'ipb-blocklist' => 'View existing blocks',
30063005 'ipb-blocklist-contribs' => 'Contributions for $1',
30073006 'unblockip' => 'Unblock user',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r16287* (bug 4434) Show block log fragment on Special:Blockiprobchurch14:36, 30 August 2006

Status & tagging log