r77224 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77223‎ | r77224 | r77225 >
Date:09:37, 24 November 2010
Author:dale
Status:deferred
Tags:
Comment:
timed text links go to new tab
Modified paths:
  • /branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js
@@ -609,10 +609,6 @@
610610 });
611611 },
612612
613 - showMiroSubs: function(){
614 -
615 - },
616 -
617613 /**
618614 * Utility function to assist in menu build out:
619615 * Get menu line item (li) html: <li><a> msgKey </a></li>
@@ -867,7 +863,7 @@
868864 var $playerTarget = this.embedPlayer.$interface;
869865 var $textTarget = $playerTarget.find( '.track_' + source.category + ' span' );
870866 // If we are missing the target add it:
871 - if( $textTarget.length == 0) {
 867+ if( $textTarget.length == 0 ) {
872868 this.addItextDiv( source.category );
873869 // Re-grab the textTarget:
874870 $textTarget = $playerTarget.find( '.track_' + source.category + ' span' );
@@ -884,8 +880,11 @@
885881 }
886882 // Update text ( use "html" instead of "text" so that parsers can swap in html for formating
887883 $textTarget.html( text );
 884+
 885+ // Update any links to point to
 886+ $textTarget.find( 'a' ).attr( 'target', '_new' );
888887 }
889 - //mw.log( ' len: ' + $textTarget.length + ' ' + $textTarget.html() );
 888+ // mw.log( ' len: ' + $textTarget.length + ' ' + $textTarget.html() );
890889 // Update the prev text:
891890 this.prevText[ source.category ] = text;
892891 },

Status & tagging log