r77200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77199‎ | r77200 | r77201 >
Date:22:54, 23 November 2010
Author:reedy
Status:deferred
Tags:
Comment:
Define version as a constant, use in debug printing
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -88,13 +88,15 @@
8989 $wgLDAPUniqueBlockLogin = array(); //Currently unused
9090 $wgLDAPUniqueRenameUser = array(); //Currently unused
9191
 92+define( "LDAPAUTHVERSION", "1.2d" );
 93+
9294 /**
9395 * Add extension information to Special:Version
9496 */
9597 $wgExtensionCredits['other'][] = array(
9698 'path' => __FILE__,
9799 'name' => 'LDAP Authentication Plugin',
98 - 'version' => '1.2d',
 100+ 'version' => LDAPAUTHVERSION,
99101 'author' => 'Ryan Lane',
100102 'descriptionmsg' => 'ldapauthentication-desc',
101103 'url' => 'http://www.mediawiki.org/wiki/Extension:LDAP_Authentication',
@@ -1699,7 +1701,7 @@
17001702 if ( isset( $debugArr ) ) {
17011703 $debugText = $debugText . " " . implode( "::", $debugArr );
17021704 }
1703 - wfDebugLog( 'ldap', $debugText, false );
 1705+ wfDebugLog( 'ldap', LDAPAUTHVERSION . ' ' . $debugText, false );
17041706 }
17051707 }
17061708

Status & tagging log