r77194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77193‎ | r77194 | r77195 >
Date:22:23, 23 November 2010
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Minor note about checkbox usage.

Sign-offs checkboxes should be marked as disabled since we do not
support the removal of a flag in the backend. This is actually
confusing.
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -654,6 +654,7 @@
655655 '</div>';
656656 }
657657
 658+ /** TODO : checkboxes should be disabled if user already has set the flag */
658659 protected function signoffForm() {
659660 $form = Xml::element( 'legend', array(), wfMsg( 'code-signoff-legend' ) );
660661 foreach ( CodeRevision::getPossibleFlags() as $flag ) {

Comments

#Comment by Reedy (talk | contribs)   22:24, 23 November 2010

Status & tagging log