r77186 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77185‎ | r77186 | r77187 >
Date:21:37, 23 November 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 26089) add block expiration to blockinfo
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -121,7 +121,7 @@
122122 $this->addJoinConds( array(
123123 'ipblocks' => array( 'LEFT JOIN', 'ipb_user=u1.user_id' ),
124124 $u2 => array( 'LEFT JOIN', 'ipb_by=u2.user_id' ) ) );
125 - $this->addFields( array( 'ipb_reason', 'u2.user_name AS blocker_name' ) );
 125+ $this->addFields( array( 'ipb_reason', 'u2.user_name AS blocker_name', 'ipb_expiry' ) );
126126 }
127127
128128 $data = array();
@@ -147,6 +147,7 @@
148148 if ( isset( $this->prop['blockinfo'] ) && !is_null( $row->blocker_name ) ) {
149149 $data[$name]['blockedby'] = $row->blocker_name;
150150 $data[$name]['blockreason'] = $row->ipb_reason;
 151+ $data[$name]['blockexpiry'] = $row->ipb_expiry;
151152 }
152153
153154 if ( isset( $this->prop['emailable'] ) && $user->canReceiveEmail() ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -534,6 +534,7 @@
535535 * (bug 25987) prop=info&inprop=watched now also works for missing pages
536536 * (bug 26006) prop=langlinks now allows obtaining full URL
537537 * (bug 26075) ApiDelete.php now calls correctly ArticleDelete hook
 538+* (bug 26089) add block expiration to blockinfo
538539
539540 === Languages updated in 1.17 ===
540541

Follow-up revisions

RevisionCommit summaryAuthorDate
r772851.16wmf4: MFT r77186catrope13:26, 25 November 2010

Comments

#Comment by MZMcBride (talk | contribs)   23:57, 23 November 2010

Mixing tabs and spaces.

#Comment by Hashar (talk | contribs)   07:24, 24 November 2010

spaces fixed in a future revision.

Status & tagging log