r77165 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77164‎ | r77165 | r77166 >
Date:16:06, 23 November 2010
Author:demon
Status:deferred
Tags:
Comment:
MFT r77132
Modified paths:
  • /branches/chad-pre-wmf-merge/extensions/FlaggedRevs (modified) (history)
  • /branches/chad-pre-wmf-merge/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /branches/chad-pre-wmf-merge/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /branches/chad-pre-wmf-merge/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: branches/chad-pre-wmf-merge/extensions/FlaggedRevs/FlaggedRevs.php
@@ -491,7 +491,7 @@
492492 $wgHooks['LoadExtensionSchemaUpdates'][] = 'FlaggedRevsHooks::addSchemaUpdates';
493493
494494 # Performance Don't show content on diff
495 -$wgHooks['ArticleContentOnDiff'][] = 'FlaggedRevsHooks::addCustomHtml';
 495+$wgHooks['ArticleContentOnDiff'][] = 'FlaggedRevsHooks::onArticleContentOnDiff';
496496
497497 # ########
498498
Index: branches/chad-pre-wmf-merge/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1813,14 +1813,13 @@
18141814 /*
18151815 * If an article is reviewable, get custom article contents from the FlaggedArticleView
18161816 */
1817 - public static function addCustomHtml( $diffEngine, $out ) {
 1817+ public static function onArticleContentOnDiff( $diffEngine, $out ) {
18181818 $fa = FlaggedArticle::getTitleInstance( $out->getTitle() );
18191819 if ( !$fa->isReviewable() ) {
18201820 return true; // nothing to do
18211821 }
1822 -
18231822 $view = FlaggedArticleView::singleton();
1824 - $view->addCustomHtml( $out );
 1823+ $view->addCustomContentHtml( $out );
18251824 return false;
18261825 }
18271826
Index: branches/chad-pre-wmf-merge/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -1814,10 +1814,11 @@
18151815 }
18161816
18171817 /*
1818 - * If this is a diff page then replace the article contents with a link to the specific revision.
1819 - * This will be replaced with artice content using javascript and an api call.
 1818+ * If this is a diff page then replace the article contents with a link
 1819+ * to the specific revision. This will be replaced with article content
 1820+ * using javascript and an api call.
18201821 */
1821 - public function addCustomHtml( OutputPage $out ) {
 1822+ public function addCustomContentHtml( OutputPage $out ) {
18221823 global $wgTitle;
18231824 $this->load();
18241825 if ( $out->getRevisionId() ) {
Property changes on: branches/chad-pre-wmf-merge/extensions/FlaggedRevs
___________________________________________________________________
Modified: svn:mergeinfo
18251826 Merged /trunk/extensions/FlaggedRevs:r77132

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77132* Renamed addCustomHTML hooks...aaron05:54, 23 November 2010

Status & tagging log