r77162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77161‎ | r77162 | r77163 >
Date:15:45, 23 November 2010
Author:catrope
Status:ok
Tags:
Comment:
UploadWizard: Ran stylize.php on all .php files
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardDependencyLoader.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardMessages.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardTutorial.php (modified) (history)
  • /trunk/extensions/UploadWizard/generateMinifiedResources.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizardHooks.php
@@ -1,14 +1,14 @@
2 -<?php
 2+<?php
33
44 /**
55 * Contains list of related resources and hooks which anticipate the use of Resource Loader, whenever that is released
66 */
77 class UploadWizardHooks {
8 -
 8+
99 /* We define scripts here for Resource Loader, but in the meantime we are going to load these the old-fashioned way
1010 (see SpecialUploadWizard.php).
1111
12 - So this list of scripts has to be topologically-sorted by hand. That is, the depended-upon stuff comes first.
 12+ So this list of scripts has to be topologically-sorted by hand. That is, the depended-upon stuff comes first.
1313 There can be no circular dependencies. */
1414
1515 public static $modules = array(
@@ -60,15 +60,15 @@
6161 'resources/mw.UploadWizardUtil.js',
6262
6363 // interface libraries
64 - 'resources/mw.GroupProgressBar.js',
 64+ 'resources/mw.GroupProgressBar.js',
6565
6666 // UploadWizard specific abstractions
6767 'resources/mw.UploadWizardDeed.js',
6868 'resources/mw.UploadWizardLicenseInput.js',
6969
70 - // main library
 70+ // main library
7171 'resources/mw.UploadWizard.js',
72 -
 72+
7373 // launcher
7474 'UploadWizardPage.js'
7575 ),
@@ -133,7 +133,7 @@
134134 'resources/jquery.ui/themes/vector/jquery.ui.datepicker.css',
135135 'resources/jquery.ui/themes/vector/jquery.ui.progressbar.css',
136136 ),
137 - 'messages' => array(
 137+ 'messages' => array(
138138 'linktest',
139139 'pluraltest',
140140 'magictest',
@@ -276,10 +276,10 @@
277277 ),
278278 ),
279279 );
280 -
 280+
281281 /*
282282 * ResourceLoaderRegisterModules hook
283 - *
 283+ *
284284 * Adds modules to ResourceLoader
285285 */
286286 public static function resourceLoaderRegisterModules( &$resourceLoader ) {
@@ -287,7 +287,7 @@
288288 if ( $wgUploadWizardDisableResourceLoader ) {
289289 return true;
290290 }
291 -
 291+
292292 $localpath = dirname( __FILE__ );
293293 $remotepath = "$wgExtensionAssetsPath/UploadWizard";
294294 foreach ( self::$modules as $name => $resources ) {
Index: trunk/extensions/UploadWizard/UploadWizardTutorial.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * Class to encapsulate all the html generation associated with the UploadWizard tutorial.
 5+ * Class to encapsulate all the html generation associated with the UploadWizard tutorial.
66 * Might be a start for a subclass of UploadWizard, if we ever free it of its WMF-oriented features
77 * So that non-WMF'ers can use it
88 */
@@ -23,8 +23,8 @@
2424 const IMAGEMAP_ID = 'tutorialMap';
2525
2626 /**
27 - * Fetches appropriate HTML for the tutorial portion of the wizard.
28 - * Looks up an image on the current wiki. This will work as is on Commons, and will also work
 27+ * Fetches appropriate HTML for the tutorial portion of the wizard.
 28+ * Looks up an image on the current wiki. This will work as is on Commons, and will also work
2929 * on test wikis that enable instantCommons.
3030 * @param {String} $langCode language code as used by MediaWiki, similar but not identical to ISO 639-1.
3131 * @return {String} html that will display the tutorial.
@@ -37,10 +37,10 @@
3838 $tutorialHtml = '';
3939
4040 $langCode = $wgLang->getCode();
41 -
 41+
4242 $tutorialFile = false;
43 - // getFile returns false if it can't find the right file
44 - if ( ! $tutorialFile = self::getFile( $langCode ) ) {
 43+ // getFile returns false if it can't find the right file
 44+ if ( ! $tutorialFile = self::getFile( $langCode ) ) {
4545 $error = 'localized-file-missing';
4646 if ( $langCode !== 'en' ) {
4747 $tutorialFile = self::getFile( 'en' );
@@ -54,8 +54,8 @@
5555
5656 if ( $tutorialFile ) {
5757 // XXX TODO if the client can handle SVG, we could also just send it the unscaled thumb, client-scaled into a DIV or something.
58 - // if ( client can handle SVG ) {
59 - // $tutorialThumbnailImage->getUnscaledThumb();
 58+ // if ( client can handle SVG ) {
 59+ // $tutorialThumbnailImage->getUnscaledThumb();
6060 // }
6161 // put it into a div of appropriate dimensions.
6262
@@ -66,7 +66,7 @@
6767 $error = 'cannot-transform';
6868 }
6969 } else {
70 - $error = 'file-missing';
 70+ $error = 'file-missing';
7171 }
7272
7373 if ( $error !== null ) {
@@ -74,17 +74,17 @@
7575 }
7676
7777 return $errorHtml . $tutorialHtml;
78 -
79 - }
8078
 79+ }
 80+
8181 /**
8282 * Get tutorial file for a particular language, or false if not available.
8383 * @param {String} $langCode: language Code
84 - * @return {File|false}
 84+ * @return {File|false}
8585 */
8686 public static function getFile( $langCode ) {
8787 $tutorialName = str_replace( '$1', $langCode, self::NAME_TEMPLATE );
88 - $tutorialTitle = Title::newFromText( $tutorialName, NS_FILE );
 88+ $tutorialTitle = Title::newFromText( $tutorialName, NS_FILE );
8989 return wfFindFile( $tutorialTitle );
9090 }
9191
@@ -95,7 +95,7 @@
9696 */
9797 public static function getImageHtml( $thumb ) {
9898 // here we use the not-yet-forgotten HTML imagemap to add a clickable area to the tutorial image.
99 - // we could do more special effects with hovers and images and such, not to mention SVG scripting,
 99+ // we could do more special effects with hovers and images and such, not to mention SVG scripting,
100100 // but we aren't sure what we want yet...
101101 $img = Html::element( 'img', array(
102102 'src' => $thumb->getUrl(),
@@ -104,7 +104,7 @@
105105 'usemap' => '#' . self::IMAGEMAP_ID
106106 ) );
107107 $areaAltText = wfMsg( 'mwe-upwiz-help-desk' );
108 - $area = Html::element( 'area', array(
 108+ $area = Html::element( 'area', array(
109109 'shape' => 'rect',
110110 'coords' => self::HELPDESK_BUTTON_COORDS,
111111 'href' => self::HELPDESK_URL,
Index: trunk/extensions/UploadWizard/generateMinifiedResources.php
@@ -13,7 +13,7 @@
1414 parent::__construct();
1515 $this->mDescription = 'Generate combined and minified JS and CSS for UploadWizard';
1616 }
17 -
 17+
1818 public function execute() {
1919 $dependencyLoader = new UploadWizardDependencyLoader();
2020 $dependencyLoader->writeOptimizedFiles();
Index: trunk/extensions/UploadWizard/UploadWizardDependencyLoader.php
@@ -4,14 +4,14 @@
55 * What's that you say? ANOTHER way to load dependencies? Everyone's doing it.
66 *
77 * Doing resource loading the old-fashioned way for now until Resource Loader or something becomes the standard.
8 - * We anticipate that Resource Loader will be available sometime in late 2010 or early 2011,
 8+ * We anticipate that Resource Loader will be available sometime in late 2010 or early 2011,
99 * so we define scripts in the hooks that Resource Loader will expect, over in UploadWizardHooks.php.
1010 *
1111 * Since the resources are defined in PHP, it was convenient to write the minifier routines here too.
12 - * We do not expect to minify on the fly in MediaWiki; those rotutines will be called by
 12+ * We do not expect to minify on the fly in MediaWiki; those rotutines will be called by
1313 * developer scripts to write minified files before committing to the source code repository.
1414 *
15 - * (Previously the usability projects had used Makefiles, but then had to keep dependencies in sync in
 15+ * (Previously the usability projects had used Makefiles, but then had to keep dependencies in sync in
1616 * PHP and the Makefile). I started to write a PHP file that then would write a Makefile and realized
1717 * this was getting a bit insane.
1818 *
@@ -24,7 +24,7 @@
2525 const SCRIPTS_COMBINED = 'combined.js';
2626 const STYLES_MINIFIED = 'combined.min.css';
2727 const SCRIPTS_MINIFIED = 'combined.min.js';
28 -
 28+
2929 protected $scripts;
3030 protected $inlineScripts;
3131 protected $styles;
@@ -112,7 +112,7 @@
113113 $dirStyleCombinedUrls = array();
114114 $dirStyleMinifiedUrls = array();
115115 $dirStylesMap = array();
116 - foreach( $this->styles as $style ) {
 116+ foreach ( $this->styles as $style ) {
117117 $dir = dirname( $style );
118118 if ( !isset( $dirStylesMap[$dir] ) ) {
119119 $dirStylesMap[$dir] = array();
@@ -132,14 +132,14 @@
133133 $this->writeStyleImporter( $dirStyleMinifiedUrls, $resourceDir . '/' . self::STYLES_MINIFIED );
134134
135135 // scripts are easy, they don't (or shouldn't) refer to other resources with relative paths
136 - $scriptsCombinedFile = $resourceDir . '/'. self::SCRIPTS_COMBINED;
 136+ $scriptsCombinedFile = $resourceDir . '/' . self::SCRIPTS_COMBINED;
137137 $this->concatenateFiles( $this->scripts, $scriptsCombinedFile );
138138 $this->writeMinifiedJs( $scriptsCombinedFile, $resourceDir . '/' . self::SCRIPTS_MINIFIED );
139139 }
140140
141141 /**
142 - * Since I couldn't figure out how to solve the CSS minification issue and how
143 - * it broke relative paths for images, we'll minify one file per directory.
 142+ * Since I couldn't figure out how to solve the CSS minification issue and how
 143+ * it broke relative paths for images, we'll minify one file per directory.
144144 * This means we'll need a "master" file to import them all. We can use CSS @import,
145145 * It's supported by browsers later than NS 4.0 or IE 4.0.
146146 * @param {Array} $urls : list of urls
@@ -148,27 +148,27 @@
149149 function writeStyleImporter( $urls, $outputFile ) {
150150 $fp = fopen( $outputFile, 'w' );
151151 if ( ! $fp ) {
152 - print "couldn't open $outputFile for writing\n";
 152+ print "couldn't open $outputFile for writing\n";
153153 exit;
154154 }
155 - foreach ( $urls as $url ) {
 155+ foreach ( $urls as $url ) {
156156 fwrite( $fp, "@import \"$url\";\n" );
157157 }
158158 fclose( $fp );
159159 }
160 -
 160+
161161 /**
162162 * Concatenates several files on the filesystem into one.
163 - * @param {Array} filenames
164 - * @param {String} filename to concatenate all files into. Will replace existing contents
 163+ * @param {Array} filenames
 164+ * @param {String} filename to concatenate all files into. Will replace existing contents
165165 */
166 - private function concatenateFiles( $files, $outputFile ) {
 166+ private function concatenateFiles( $files, $outputFile ) {
167167 $fp = fopen( $outputFile, 'w' );
168168 if ( ! $fp ) {
169 - print "couldn't open $outputFile for writing";
 169+ print "couldn't open $outputFile for writing";
170170 exit;
171171 }
172 - foreach ( $files as $file ) {
 172+ foreach ( $files as $file ) {
173173 fwrite( $fp, file_get_contents( $file ) );
174174 }
175175 fclose( $fp );
@@ -182,7 +182,7 @@
183183 private function writeMinifiedJs( $inputFile, $outputFile ) {
184184 $fp = fopen( $outputFile, 'w' );
185185 if ( ! $fp ) {
186 - print "couldn't open $outputFile for writing";
 186+ print "couldn't open $outputFile for writing";
187187 exit;
188188 }
189189 fwrite( $fp, JSMin::minify( file_get_contents( $inputFile ) ) );
@@ -207,15 +207,15 @@
208208
209209 // remove whitespace immediately before an open-curly
210210 $contents = preg_replace( '/\s*\{/', '{', $contents );
211 -
 211+
212212 // remove /* ... */ comments, potentially on multiple lines
213 - // CAUTION: gets edge cases wrong, like nested or quoted comments.
 213+ // CAUTION: gets edge cases wrong, like nested or quoted comments.
214214 // Not for use with nuclear reactors.
215215 $contents = preg_replace( '/\/\*.*?\*\//s', '', $contents );
216216
217217 $fp = fopen( $outputFile, 'w' );
218218 if ( ! $fp ) {
219 - print "couldn't open $outputFile for writing";
 219+ print "couldn't open $outputFile for writing";
220220 exit;
221221 }
222222 fwrite( $fp, $contents );
Index: trunk/extensions/UploadWizard/UploadWizardMessages.php
@@ -1,9 +1,9 @@
22 <?php
3 -/**
 3+/**
44 * UploadWizardMessages
55 *
66 * Simple class to take messages from a modules' i18n.php and dump them into Javascript.
7 - *
 7+ *
88 * @file
99 * @ingroup Upload
1010 */
@@ -28,14 +28,14 @@
2929 // Empty out messages in the current scope
3030 $messages = array();
3131 require( $wgExtensionMessagesFiles[ $moduleName ] );
32 -
 32+
3333 // iterate over the default messages, and get this wiki's current messages
34 - // presumably this will include local overrides in MediaWiki: space
 34+ // presumably this will include local overrides in MediaWiki: space
3535 $messagesForJs = array();
36 -
 36+
3737 // 'en' is the default language, so it will be the most complete
3838 foreach ( array_keys( $messages['en'] ) as $key ) {
39 - $messagesForJs[ $key ] = wfMsgGetKey( $key, /*DB*/true, $language, /*Transform*/false );
 39+ $messagesForJs[ $key ] = wfMsgGetKey( $key, /*DB*/true, $language, /*Transform*/false );
4040 }
4141
4242 $messagesJson = FormatJson::encode( $messagesForJs );
@@ -46,14 +46,14 @@
4747 static function getNormalizedLangCode( $langCode ) {
4848 global $wgLang;
4949 // Check the langCode
50 - if( !$langCode) {
 50+ if ( !$langCode ) {
5151 if ( $wgLang ) {
5252 $langCode = $wgLang->getCode();
5353 } else {
5454 $langCode = 'en'; // desperation
5555 }
56 - }
57 -
 56+ }
 57+
5858 }
5959
6060 }
Index: trunk/extensions/UploadWizard/UploadWizard.php
@@ -30,21 +30,21 @@
3131
3232
3333
34 -$dir = dirname(__FILE__);
 34+$dir = dirname( __FILE__ );
3535
3636 $wgExtensionMessagesFiles['UploadWizard'] = $dir . '/UploadWizard.i18n.php';
3737 $wgExtensionAliasesFiles['UploadWizard'] = $dir . '/UploadWizard.alias.php';
3838
3939 # Require modules, includeing the special page
40 -foreach ( array( 'SpecialUploadWizard',
41 - 'UploadWizardMessages',
 40+foreach ( array( 'SpecialUploadWizard',
 41+ 'UploadWizardMessages',
4242 'UploadWizardHooks',
4343 'UploadWizardTutorial',
4444 'UploadWizardDependencyLoader' ) as $module ) {
4545 $wgAutoloadLocalClasses[$module] = $dir . "/" . $module . ".php";
4646 }
47 -
4847
 48+
4949 # Let the special page be a special center of unique specialness
5050 $wgSpecialPages['UploadWizard'] = 'SpecialUploadWizard';
5151 $wgSpecialPageGroups['UploadWizard'] = 'media';
Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
@@ -15,7 +15,7 @@
1616
1717 // $request is the request (usually wgRequest)
1818 // $par is everything in the URL after Special:UploadWizard. Not sure what we can use it for
19 - public function __construct( $request=null, $par=null ) {
 19+ public function __construct( $request = null, $par = null ) {
2020 global $wgRequest;
2121 // here we would configure ourselves based on stuff in $request and $wgRequest, but so far, we
2222 // don't have such things
@@ -26,21 +26,21 @@
2727 // at some point, if we completely subsume its functionality, change that to point here again,
2828 // but then we'll need to process non-JS uploads in the same way Special:Upload does.
2929 $this->simpleForm = new UploadWizardSimpleForm();
30 - $this->simpleForm->setTitle(
 30+ $this->simpleForm->setTitle(
3131 SpecialPage::getTitleFor( 'Upload' )
3232 );
3333 }
3434
3535 /**
3636 * Replaces default execute method
37 - * Checks whether uploading enabled, user permissions okay,
38 - * @param $subPage, e.g. the "foo" in Special:UploadWizard/foo.
 37+ * Checks whether uploading enabled, user permissions okay,
 38+ * @param $subPage, e.g. the "foo" in Special:UploadWizard/foo.
3939 */
4040 public function execute( $subPage ) {
4141 global $wgLang, $wgUser, $wgOut, $wgExtensionAssetsPath,
4242 $wgUploadWizardDebug, $wgUploadWizardDisableResourceLoader;
4343
44 - // side effects: if we can't upload, will print error page to wgOut
 44+ // side effects: if we can't upload, will print error page to wgOut
4545 // and return false
4646 if ( !( $this->isUploadAllowed() && $this->isUserUploadAllowed( $wgUser ) ) ) {
4747 return;
@@ -56,10 +56,10 @@
5757 $wgOut->addHTML( '</noscript>' );
5858
5959
60 - // global javascript variables
 60+ // global javascript variables
6161 $this->addJsVars( $subPage );
62 -
63 - // dependencies (css, js)
 62+
 63+ // dependencies (css, js)
6464 if ( !$wgUploadWizardDisableResourceLoader && class_exists( 'ResourceLoader' ) ) {
6565 $wgOut->addModules( 'ext.uploadWizard' );
6666 } else {
@@ -73,11 +73,11 @@
7474 $dependencyLoader->outputHtml( $wgOut, $basepath );
7575 }
7676 }
77 -
 77+
7878 // where the uploadwizard will go
7979 // TODO import more from UploadWizard's createInterface call.
8080 $wgOut->addHTML( self::getWizardHtml() );
81 -
 81+
8282 }
8383
8484 /**
@@ -119,7 +119,7 @@
120120 global $wgOut, $wgEnableAPI;
121121
122122 // Check uploading enabled
123 - if( !UploadBase::isEnabled() ) {
 123+ if ( !UploadBase::isEnabled() ) {
124124 $wgOut->showErrorPage( 'uploaddisabled', 'uploaddisabledtext' );
125125 return false;
126126 }
@@ -127,17 +127,17 @@
128128 // XXX does wgEnableAPI affect all uploads too?
129129
130130 // Check whether we actually want to allow changing stuff
131 - if( wfReadOnly() ) {
 131+ if ( wfReadOnly() ) {
132132 $wgOut->readOnlyPage();
133133 return false;
134 - }
 134+ }
135135
136136 // we got all the way here, so it must be okay to upload
137137 return true;
138138 }
139139
140140 /**
141 - * Check if the user can upload
 141+ * Check if the user can upload
142142 * Side effect: will print error page to wgOut if cannot upload.
143143 * @param User
144144 * @return boolean -- true if can upload
@@ -145,8 +145,8 @@
146146 private function isUserUploadAllowed( $user ) {
147147 global $wgOut, $wgGroupPermissions;
148148
149 - if( !$user->isAllowed( 'upload' ) ) {
150 - if( !$user->isLoggedIn() && ( $wgGroupPermissions['user']['upload']
 149+ if ( !$user->isAllowed( 'upload' ) ) {
 150+ if ( !$user->isLoggedIn() && ( $wgGroupPermissions['user']['upload']
151151 || $wgGroupPermissions['autoconfirmed']['upload'] ) ) {
152152 // Custom message if logged-in users without any special rights can upload
153153 $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
@@ -157,7 +157,7 @@
158158 }
159159
160160 // Check blocks
161 - if( $user->isBlocked() ) {
 161+ if ( $user->isBlocked() ) {
162162 $wgOut->blockedPage();
163163 return false;
164164 }
@@ -167,7 +167,7 @@
168168 }
169169
170170 /**
171 - * Return the basic HTML structure for the entire page
 171+ * Return the basic HTML structure for the entire page
172172 * Will be enhanced by the javascript to actually do stuff
173173 * @return {String} html
174174 */
@@ -178,23 +178,23 @@
179179
180180 // the arrow steps
181181 . '<ul id="mwe-upwiz-steps">'
182 - . '<li id="mwe-upwiz-step-tutorial"><div>' . wfMsg('mwe-upwiz-step-tutorial') . '</div></li>'
183 - . '<li id="mwe-upwiz-step-file"><div>' . wfMsg('mwe-upwiz-step-file') . '</div></li>'
184 - . '<li id="mwe-upwiz-step-deeds"><div>' . wfMsg('mwe-upwiz-step-deeds') . '</div></li>'
185 - . '<li id="mwe-upwiz-step-details"><div>' . wfMsg('mwe-upwiz-step-details') . '</div></li>'
186 - . '<li id="mwe-upwiz-step-thanks"><div>' . wfMsg('mwe-upwiz-step-thanks') . '</div></li>'
 182+ . '<li id="mwe-upwiz-step-tutorial"><div>' . wfMsg( 'mwe-upwiz-step-tutorial' ) . '</div></li>'
 183+ . '<li id="mwe-upwiz-step-file"><div>' . wfMsg( 'mwe-upwiz-step-file' ) . '</div></li>'
 184+ . '<li id="mwe-upwiz-step-deeds"><div>' . wfMsg( 'mwe-upwiz-step-deeds' ) . '</div></li>'
 185+ . '<li id="mwe-upwiz-step-details"><div>' . wfMsg( 'mwe-upwiz-step-details' ) . '</div></li>'
 186+ . '<li id="mwe-upwiz-step-thanks"><div>' . wfMsg( 'mwe-upwiz-step-thanks' ) . '</div></li>'
187187 . '</ul>'
188188
189189 // the individual steps, all at once
190190 . '<div id="mwe-upwiz-content">'
191191
192192 . '<div class="mwe-upwiz-stepdiv" id="mwe-upwiz-stepdiv-tutorial">'
193 - . '<div id="mwe-upwiz-tutorial">'
 193+ . '<div id="mwe-upwiz-tutorial">'
194194 . UploadWizardTutorial::getHtml()
195195 . '</div>'
196196 . '<div class="mwe-upwiz-buttons">'
197197 . '<button class="mwe-upwiz-button-next">' . wfMsg( "mwe-upwiz-next" ) . '</button>'
198 - . '</div>'
 198+ . '</div>'
199199 . '</div>'
200200
201201 . '<div class="mwe-upwiz-stepdiv ui-helper-clearfix" id="mwe-upwiz-stepdiv-file">'
@@ -202,7 +202,7 @@
203203 . '<div id="mwe-upwiz-filelist" class="ui-corner-all"></div>'
204204 . '<div id="mwe-upwiz-upload-ctrls" class="mwe-upwiz-file ui-helper-clearfix">'
205205 . '<div id="mwe-upwiz-add-file-container" class="mwe-upwiz-add-files-0">'
206 - . '<button id="mwe-upwiz-add-file">' . wfMsg("mwe-upwiz-add-file-0") . '</button>'
 206+ . '<button id="mwe-upwiz-add-file">' . wfMsg( "mwe-upwiz-add-file-0" ) . '</button>'
207207 . '</div>'
208208 . '<div id="mwe-upwiz-upload-ctrl-container">'
209209 . '<button id="mwe-upwiz-upload-ctrl">' . wfMsg( "mwe-upwiz-upload" ) . '</button>'
@@ -212,17 +212,17 @@
213213 . '<div id="mwe-upwiz-continue" class="ui-helper-clearfix"></div>'
214214 . '</div>'
215215 . '<div class="mwe-upwiz-buttons">'
216 - . '<div class="mwe-upwiz-file-next-all-ok mwe-upwiz-file-endchoice">'
217 - . wfMsg( "mwe-upwiz-file-all-ok" )
 216+ . '<div class="mwe-upwiz-file-next-all-ok mwe-upwiz-file-endchoice">'
 217+ . wfMsg( "mwe-upwiz-file-all-ok" )
218218 . '<button class="mwe-upwiz-button-next">' . wfMsg( "mwe-upwiz-next-file" ) . '</button>'
219219 . '</div>'
220 - . '<div class="mwe-upwiz-file-next-some-failed mwe-upwiz-file-endchoice">'
221 - . wfMsg( "mwe-upwiz-file-some-failed" )
 220+ . '<div class="mwe-upwiz-file-next-some-failed mwe-upwiz-file-endchoice">'
 221+ . wfMsg( "mwe-upwiz-file-some-failed" )
222222 . '<button class="mwe-upwiz-button-retry">' . wfMsg( "mwe-upwiz-file-retry" ) . '</button>'
223223 . '<button class="mwe-upwiz-button-next">' . wfMsg( "mwe-upwiz-next-file-despite-failures" ) . '</button>'
224224 . '</div>'
225 - . '<div class="mwe-upwiz-file-next-all-failed mwe-upwiz-file-endchoice">'
226 - . wfMsg( "mwe-upwiz-file-all-failed" )
 225+ . '<div class="mwe-upwiz-file-next-all-failed mwe-upwiz-file-endchoice">'
 226+ . wfMsg( "mwe-upwiz-file-all-failed" )
227227 . '<button class="mwe-upwiz-button-retry"> ' . wfMsg( "mwe-upwiz-file-retry" ) . '</button>'
228228 . '</div>'
229229 . '</div>'
@@ -241,8 +241,8 @@
242242 . '<div class="mwe-upwiz-stepdiv" id="mwe-upwiz-stepdiv-details">'
243243 . '<div id="mwe-upwiz-macro">'
244244 . '<div id="mwe-upwiz-macro-progress" class="ui-helper-clearfix"></div>'
245 - . '<div id="mwe-upwiz-macro-choice">'
246 - . '<div>' . wfMsg( 'mwe-upwiz-details-intro' ) . '</div>'
 245+ . '<div id="mwe-upwiz-macro-choice">'
 246+ . '<div>' . wfMsg( 'mwe-upwiz-details-intro' ) . '</div>'
247247 . '</div>'
248248 . '<div id="mwe-upwiz-macro-files"></div>'
249249 . '</div>'
@@ -265,7 +265,7 @@
266266
267267 . '</div>';
268268 }
269 -
 269+
270270 }
271271
272272

Status & tagging log