r77145 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77144‎ | r77145 | r77146 >
Date:11:21, 23 November 2010
Author:maxsem
Status:ok
Tags:
Comment:
Fixed $fname in some places
Modified paths:
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMysql.php
@@ -249,7 +249,7 @@
250250 * Returns estimated count, based on EXPLAIN output
251251 * Takes same arguments as Database::select()
252252 */
253 - public function estimateRowCount( $table, $vars='*', $conds='', $fname = 'Database::estimateRowCount', $options = array() ) {
 253+ public function estimateRowCount( $table, $vars='*', $conds='', $fname = 'DatabaseMysql::estimateRowCount', $options = array() ) {
254254 $options['EXPLAIN'] = true;
255255 $res = $this->select( $table, $vars, $conds, $fname, $options );
256256 if ( $res === false ) {
Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -973,7 +973,7 @@
974974
975975 function fieldInfo( $table, $field ) {
976976 if ( is_array( $table ) ) {
977 - throw new DBUnexpectedError( $this, 'Database::fieldInfo called with table array!' );
 977+ throw new DBUnexpectedError( $this, 'DatabaseOracle::fieldInfo called with table array!' );
978978 }
979979 return $this->fieldInfoMulti ($table, $field);
980980 }
Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -1037,7 +1037,7 @@
10381038 * more of IGNORE, LOW_PRIORITY
10391039 * @return Boolean
10401040 */
1041 - public function update( $table, $values, $conds, $fname = 'Database::update',
 1041+ public function update( $table, $values, $conds, $fname = 'DatabaseIbm_db2::update',
10421042 $options = array() )
10431043 {
10441044 $table = $this->tableName( $table );
@@ -1062,10 +1062,10 @@
10631063 *
10641064 * Use $conds == "*" to delete all rows
10651065 */
1066 - public function delete( $table, $conds, $fname = 'Database::delete' ) {
 1066+ public function delete( $table, $conds, $fname = 'DatabaseIbm_db2::delete' ) {
10671067 if ( !$conds ) {
10681068 throw new DBUnexpectedError( $this,
1069 - 'Database::delete() called with no conditions' );
 1069+ 'DatabaseIbm_db2::delete() called with no conditions' );
10701070 }
10711071 $table = $this->tableName( $table );
10721072 $sql = "DELETE FROM $table";
@@ -1463,7 +1463,7 @@
14641464 * @return Bool
14651465 */
14661466 public function indexUnique ( $table, $index,
1467 - $fname = 'Database::indexUnique' )
 1467+ $fname = 'DatabaseIbm_db2::indexUnique' )
14681468 {
14691469 $table = $this->tableName( $table );
14701470 $sql = <<<SQL
@@ -1518,7 +1518,7 @@
15191519 {
15201520 if ( !$conds ) {
15211521 throw new DBUnexpectedError( $this,
1522 - 'Database::deleteJoin() called with empty $conds' );
 1522+ 'DatabaseIbm_db2::deleteJoin() called with empty $conds' );
15231523 }
15241524
15251525 $delTable = $this->tableName( $delTable );

Status & tagging log