r77091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77090‎ | r77091 | r77092 >
Date:23:24, 21 November 2010
Author:reedy
Status:resolved
Tags:
Comment:
Explicitally declare variable, remove unused variable/call...
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeTagListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/WordCloud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeTagListView.php
@@ -9,10 +9,9 @@
1010
1111 function execute() {
1212 global $wgOut;
13 - $name = $this->mRepo->getName();
1413 $list = $this->mRepo->getTagList();
1514
16 - if( 0 === count( $list ) ) {
 15+ if( count( $list ) === 0 ) {
1716 $wgOut->addWikiMsg( 'code-tags-no-tags' );
1817 } else {
1918 # Show a cloud made of tags
Index: trunk/extensions/CodeReview/ui/WordCloud.php
@@ -119,7 +119,7 @@
120120 if( count( $keys ) && is_array( $keys ) ) {
121121 $tmpArray = $this->wordsArray;
122122 $this->wordsArray = array();
123 - foreach( $keys as $key => $value ) {
 123+ foreach( $keys as $value ) {
124124 $this->wordsArray[$value] = $tmpArray[$value];
125125 }
126126 }
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -3,6 +3,9 @@
44 // Special:Code/MediaWiki
55 class CodeRevisionListView extends CodeView {
66 public $mRepo, $mPath;
 7+
 8+ private $batchForm;
 9+
710 function __construct( $repoName ) {
811 global $wgRequest;
912 parent::__construct();

Follow-up revisions

RevisionCommit summaryAuthorDate
r77427Fix regression from r77091 causing checkboxes for batch status/tag changes to...catrope19:04, 29 November 2010

Status & tagging log