r77085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77084‎ | r77085 | r77086 >
Date:20:29, 21 November 2010
Author:yaron
Status:deferred
Tags:
Comment:
Removed htmlspecialchars() call around Ajax URLs - with the recent addition of other escapings, this led to a double escaping, making the "Other options" section no longer work.
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
——@@ -549,7 +549,7 @@
550550 }
551551
552552 $printer = SMWQueryProcessor::getResultPrinter( 'broadtable', SMWQueryProcessor::SPECIAL_PAGE );
553 - $url = htmlspecialchars( $skin->makeSpecialUrl( 'Ask', "showformatoptions=\" + this.value + \"" ) );
 553+ $url = $skin->makeSpecialUrl( 'Ask', "showformatoptions=' + this.value + '" );
554554
555555 foreach ( $this->m_params as $param => $value ) {
556556 if ( $param !== 'format' ) {

Status & tagging log