r77079 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77078‎ | r77079 | r77080 >
Date:17:02, 21 November 2010
Author:ialex
Status:ok
Tags:
Comment:
Per Reedy, follow-up to r77072: don't use array_merge() to add just one item
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryLangLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLangLinks.php
@@ -90,7 +90,7 @@
9191 if ( !is_null( $params['url'] ) ) {
9292 $title = Title::newFromText( "{$row->ll_lang}:{$row->ll_title}" );
9393 if ( $title ) {
94 - $entry = array_merge( $entry, array( 'url' => $title->getFullURL() ) );
 94+ $entry['url'] = $title->getFullURL();
9595 }
9696 }
9797 ApiResult::setContent( $entry, $row->ll_title );

Follow-up revisions

RevisionCommit summaryAuthorDate
r77080Per r77072 CR, followup r66872 (seemingly my crappy code from 5 months ago) l...reedy17:27, 21 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77072* (bug 26006) prop=langlinks now allows obtaining full URLialex14:04, 21 November 2010

Status & tagging log