r77043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r77042‎ | r77043 | r77044 >
Date:23:30, 19 November 2010
Author:tparscal
Status:ok
Tags:
Comment:
Removed use of self-closing button tags - IE did not understand them and was treating them as opening tags instead.
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
——@@ -194,7 +194,7 @@
195195 . UploadWizardTutorial::getHtml()
196196 . '</div>'
197197 . '<div class="mwe-upwiz-buttons">'
198 - . '<button class="mwe-upwiz-button-next" />'
 198+ . '<button class="mwe-upwiz-button-next"></button>'
199199 . '</div>'
200200 . '</div>'
201201
——@@ -210,7 +210,7 @@
211211 . '<div id="mwe-upwiz-progress" class="ui-helper-clearfix"></div>'
212212 . '</div>'
213213 . '<div class="mwe-upwiz-buttons" style="display: none"/>'
214 - . '<button class="mwe-upwiz-button-next" />'
 214+ . '<button class="mwe-upwiz-button-next"></button>'
215215 . '</div>'
216216 . '</div>'
217217
——@@ -220,7 +220,7 @@
221221 . '<div id="mwe-upwiz-deeds" class="ui-helper-clearfix"></div>'
222222 . '<div id="mwe-upwiz-deeds-custom" class="ui-helper-clearfix"></div>'
223223 . '<div class="mwe-upwiz-buttons"/>'
224 - . '<button class="mwe-upwiz-button-next" />'
 224+ . '<button class="mwe-upwiz-button-next"></button>'
225225 . '</div>'
226226 . '</div>'
227227
——@@ -233,7 +233,7 @@
234234 . '<div id="mwe-upwiz-macro-files"></div>'
235235 . '</div>'
236236 . '<div class="mwe-upwiz-buttons"/>'
237 - . '<button class="mwe-upwiz-button-next" />'
 237+ . '<button class="mwe-upwiz-button-next"></button>'
238238 . '</div>'
239239 . '</div>'
240240
——@@ -242,7 +242,7 @@
243243 . '<div class="mwe-upwiz-buttons"/>'
244244 . '<button class="mwe-upwiz-button-begin"></button>'
245245 . '<br/><button class="mwe-upwiz-button-home"></button>'
246 - . '</div>'
 246+ . '</div>'
247247 . '</div>'
248248
249249 . '</div>'

Status & tagging log