r77037 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77036‎ | r77037 | r77038 >
Date:22:15, 19 November 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added public static keywords to static methods.
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizardTutorial.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizardTutorial.php
@@ -29,7 +29,7 @@
3030 * @param {String} $langCode language code as used by MediaWiki, similar but not identical to ISO 639-1.
3131 * @return {String} html that will display the tutorial.
3232 */
33 - function getHtml() {
 33+ public static function getHtml() {
3434 global $wgLang;
3535
3636 $error = null;
@@ -82,7 +82,7 @@
8383 * @param {String} $langCode: language Code
8484 * @return {File|false}
8585 */
86 - function getFile( $langCode ) {
 86+ public static function getFile( $langCode ) {
8787 $tutorialName = str_replace( '$1', $langCode, self::NAME_TEMPLATE );
8888 $tutorialTitle = Title::newFromText( $tutorialName, NS_FILE );
8989 return wfFindFile( $tutorialTitle );
@@ -93,7 +93,7 @@
9494 * @param {ThumbnailImage} $thumb
9595 * @return {String} HTML representing the image, with clickable helpdesk button
9696 */
97 - function getImageHtml( $thumb ) {
 97+ public static function getImageHtml( $thumb ) {
9898 // here we use the not-yet-forgotten HTML imagemap to add a clickable area to the tutorial image.
9999 // we could do more special effects with hovers and images and such, not to mention SVG scripting,
100100 // but we aren't sure what we want yet...

Follow-up revisions

RevisionCommit summaryAuthorDate
r77038Mergin from r77023 thru r77037 of trunkawjrichards22:16, 19 November 2010

Status & tagging log