r77036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77035‎ | r77036 | r77037 >
Date:22:04, 19 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
fixing boolean logic
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php
@@ -222,7 +222,7 @@
223223 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit-paypal' ) );
224224 }
225225 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
226 - $form .= Html::hidden( 'PaypalRedirect', 0 );
 226+ $form .= Html::hidden( 'PaypalRedirect', false );
227227 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
228228 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
229229 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php
@@ -58,7 +58,7 @@
5959
6060 var doCheck = true;
6161 if( typeof( document.payment.PaypalRedirect.value ) !== 'undefined' ) {
62 - if( document.payment.PaypalRedirect.value == true ) {
 62+ if( document.payment.PaypalRedirect.value == 'true' ) {
6363 doCheck = false;
6464 }
6565 }

Status & tagging log