r77033 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77032‎ | r77033 | r77034 >
Date:21:23, 19 November 2010
Author:ashley
Status:ok
Tags:
Comment:
wrap the redirect message (arrow image + target page name) into a div that has the class "redirectMsg" so that the redirection arrow can be customized with on-wiki CSS instead of having to overwrite skins/common/images/redirect(ltr|rtl).png
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1571,8 +1571,9 @@
15721572 }
15731573
15741574 $imageUrl = $wgStylePath . '/common/images/redirect' . $imageDir . '.png';
1575 - return Html::element( 'img', array( 'src' => $imageUrl, 'alt' => '#REDIRECT' ) ) .
1576 - '<span class="redirectText">' . $link . '</span>';
 1575+ return '<div class="redirectMsg">' .
 1576+ Html::element( 'img', array( 'src' => $imageUrl, 'alt' => '#REDIRECT' ) ) .
 1577+ '<span class="redirectText">' . $link . '</span></div>';
15771578 }
15781579
15791580 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -206,6 +206,9 @@
207207 * Added CSS print pagination to the print stylesheets
208208 * (bug 25960) Add <link rel=canonical"> for File pages of shared/foreign
209209 file repositories.
 210+* When viewing a redirect, the redirect arrow and redirection target are both
 211+ wrapped in a div that has the class "redirectMsg" so that the redirection
 212+ arrow can be customized with CSS
210213
211214 === Bug fixes in 1.17 ===
212215 * (bug 17560) Half-broken deletion moved image files to deletion archive

Status & tagging log