r77030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77029‎ | r77030 | r77031 >
Date:20:34, 19 November 2010
Author:maxsem
Status:ok
Tags:
Comment:
SQLite types can be non-nullable
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -656,8 +656,7 @@
657657 }
658658
659659 function nullable() {
660 - // SQLite dynamic types are always nullable
661 - return true;
 660+ return !$this->info->notnull;
662661 }
663662
664663 # isKey(), isMultipleKey() not implemented, MySQL-specific concept.

Status & tagging log