r77023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77022‎ | r77023 | r77024 >
Date:18:58, 19 November 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Merging from r77001 thru r77022 of trunk
Modified paths:
  • /branches/fundraising/deployment/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php
@@ -163,7 +163,7 @@
164164 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
165165 if ( $this->paypal ) {
166166 $form .= Html::hidden( 'PaypalRedirect', false );
167 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
168168 } else {
169169 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170170 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php
@@ -163,7 +163,7 @@
164164 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
165165 if ( $this->paypal ) {
166166 $form .= Html::hidden( 'PaypalRedirect', false );
167 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
168168 } else {
169169 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170170 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php
@@ -163,7 +163,7 @@
164164 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
165165 if ( $this->paypal ) {
166166 $form .= Html::hidden( 'PaypalRedirect', false );
167 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
 167+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';return true;', 'type' => 'submit' ) );
168168 } else {
169169 $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170170 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php
@@ -195,7 +195,7 @@
196196 // cc submit button
197197 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit' ) );
198198 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
199 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;document.payment.submit();', 'type' => 'submit' ) );
 199+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;return true;', 'type' => 'submit' ) );
200200 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
201201 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
202202 wfMsg( 'payflowpro_gateway-donate-click' );
@@ -206,7 +206,7 @@
207207 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit-paypal' ) );
208208 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
209209 $form .= Html::hidden( 'PaypalRedirect', 0 );
210 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;document.payment.submit();', 'type' => 'submit' ) );
 210+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;return true;', 'type' => 'submit' ) );
211211 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
212212 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
213213
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php
@@ -208,7 +208,7 @@
209209 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit', 'style' => 'display: none;' ) );
210210 }
211211 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
212 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;document.payment.submit();', 'type' => 'submit' ) );
 212+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;return true;', 'type' => 'submit' ) );
213213 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
214214 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
215215 wfMsg( 'payflowpro_gateway-donate-click' );
@@ -223,7 +223,7 @@
224224 }
225225 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
226226 $form .= Html::hidden( 'PaypalRedirect', 0 );
227 - $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;document.payment.submit();', 'type' => 'submit' ) );
 227+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=1;return true;', 'type' => 'submit' ) );
228228 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-submessage
229229 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-form-submit
230230 return $form;
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -118,7 +118,7 @@
119119 $form .= Html::hidden( 'PaypalRedirect', false );
120120 $form .= Xml::tags( 'div',
121121 array(),
122 - Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&nbsp;&nbsp;&nbsp;<a href="#" onclick="document.payment.PaypalRedirect.value=\'true\';document.payment.submit();"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
 122+ Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&nbsp;&nbsp;&nbsp;<a href="#" onclick="document.payment.PaypalRedirect.value=\'true\';return true;"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
123123 );
124124 $form .= '</td>';
125125 $form .= '</tr>';
Property changes on: branches/fundraising/deployment/DonationInterface
___________________________________________________________________
Modified: svn:mergeinfo
126126 Merged /trunk/extensions/DonationInterface:r77002-77022

Follow-up revisions

RevisionCommit summaryAuthorDate
r77038Mergin from r77023 thru r77037 of trunkawjrichards22:16, 19 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77001Moving around log starting for transaction initiationawjrichards01:45, 19 November 2010
r77022sample configuration to run selenium against a grid servermglaser14:12, 19 November 2010

Status & tagging log