r77016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77015‎ | r77016 | r77017 >
Date:13:17, 19 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Fix fixme on r76794. Keep assignment from if, just nest it below
Modified paths:
  • /trunk/extensions/CodeReview/ui/SpecialCode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/SpecialCode.php
@@ -29,11 +29,14 @@
3030 }
3131
3232 // Add subtitle for easy navigation
33 - $repo = $view->getRepo();
34 - if ( $view instanceof CodeView && $repo ) {
35 - $wgOut->setSubtitle(
36 - wfMsgExt( 'codereview-subtitle', 'parse', CodeRepoListView::getNavItem( $repo ) )
37 - );
 33+ if ( $view instanceof CodeView ) {
 34+ $repo = $view->getRepo();
 35+
 36+ if ( $repo ) {
 37+ $wgOut->setSubtitle(
 38+ wfMsgExt( 'codereview-subtitle', 'parse', CodeRepoListView::getNavItem( $repo ) )
 39+ );
 40+ }
3841 }
3942 }
4043

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76794Fix assignment in condition, rename showCloud() to something more descriptivedemon14:15, 16 November 2010

Status & tagging log