r77013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77012‎ | r77013 | r77014 >
Date:11:25, 19 November 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed some small issues
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php
@@ -75,6 +75,8 @@
7676 $rowstart = '<li>';
7777 $rowend = "</li>\n";
7878 $plainlist = false;
 79+ $finallistsep = '';
 80+ $listsep = '';
7981 } else { // "list" and "template" format
8082 $header = '';
8183 $footer = '';
@@ -116,7 +118,7 @@
117119 $rownum = -1;
118120 while ( $row = $res->getNext() ) {
119121 $this->printRow( $row, $rownum, $rows_in_cur_column, $rows_in_cur_column, $plainlist,
120 - $header, $footer, $rowstart, $rowend, $result, $column_width );
 122+ $header, $footer, $rowstart, $rowend, $result, $column_width, $res, $listsep, $finallistsep );
121123 }
122124
123125 if ( $this->mOutroTemplate != '' ) {
@@ -143,7 +145,7 @@
144146 }
145147
146148 protected function printRow( $row, &$rownum, &$rows_in_cur_column, $rows_per_column,
147 - $plainlist, $header, $footer, $rowstart, $rowend, &$result, $column_width ) {
 149+ $plainlist, $header, $footer, $rowstart, $rowend, &$result, $column_width, $res, $listsep, $finallistsep ) {
148150 $rownum++;
149151
150152 if ( $this->mColumns > 1 ) {

Status & tagging log