r76997 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r76996‎ \| r76997 \| r76998 >
Date:	01:32, 19 November 2010
Author:	kaldari
Status:	deferred
Tags:
Comment:	making sure placeholder issue is fixed for all forms
Modified paths:	/trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnPayPal.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php
—	—	@@ -58,7 +58,7 @@
59	59
60	60	// Xml::element seems to convert html to htmlentities
61	61	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
62		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );~~
	62	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
63	63
64	64	$form .= $this->generateBillingContainer();
65	65	return $form;
—	—	@@ -165,7 +165,7 @@
166	166	$form .= Html::hidden( 'PaypalRedirect', false );
167	167	$form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
168	168	} else {
169		~~- $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'submit_form( this )', 'type' => 'submit' ) );~~
	169	+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170	170	$form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
171	171	$form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
172	172	wfMsg( 'payflowpro_gateway-donate-click' );
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php
—	—	@@ -58,7 +58,7 @@
59	59
60	60	// Xml::element seems to convert html to htmlentities
61	61	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
62		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );~~
	62	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
63	63
64	64	$form .= $this->generateBillingContainer();
65	65	return $form;
—	—	@@ -165,7 +165,7 @@
166	166	$form .= Html::hidden( 'PaypalRedirect', false );
167	167	$form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
168	168	} else {
169		~~- $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'submit_form( this )', 'type' => 'submit' ) );~~
	169	+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170	170	$form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
171	171	$form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
172	172	wfMsg( 'payflowpro_gateway-donate-click' );
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php
—	—	@@ -58,7 +58,7 @@
59	59
60	60	// Xml::element seems to convert html to htmlentities
61	61	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
62		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );~~
	62	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
63	63
64	64	$form .= $this->generateBillingContainer();
65	65	return $form;
—	—	@@ -165,7 +165,7 @@
166	166	$form .= Html::hidden( 'PaypalRedirect', false );
167	167	$form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-paypal-button' ), 'onclick' => 'document.payment.PaypalRedirect.value=\'true\';document.payment.submit();', 'type' => 'submit' ) );
168	168	} else {
169		~~- $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'submit_form( this )', 'type' => 'submit' ) );~~
	169	+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'type' => 'submit' ) );
170	170	$form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
171	171	$form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
172	172	wfMsg( 'payflowpro_gateway-donate-click' );
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php
—	—	@@ -55,7 +55,7 @@
56	56
57	57	// Xml::element seems to convert html to htmlentities
58	58	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
59		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'autocomplete' => 'off' ) );~~
	59	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
60	60
61	61	$form .= $this->generateBillingContainer();
62	62	return $form;
—	—	@@ -195,7 +195,7 @@
196	196	// cc submit button
197	197	$form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit' ) );
198	198	$form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
199		- $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;submit_form( this );', 'type' => 'submit' ) );
	199	+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;document.payment.submit();', 'type' => 'submit' ) );
200	200	$form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
201	201	$form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
202	202	wfMsg( 'payflowpro_gateway-donate-click' );
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php
—	—	@@ -55,7 +55,7 @@
56	56
57	57	// Xml::element seems to convert html to htmlentities
58	58	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
59		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'autocomplete' => 'off' ) );~~
	59	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
60	60
61	61	$form .= $this->generateBillingContainer();
62	62	return $form;
—	—	@@ -208,7 +208,7 @@
209	209	$form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit', 'style' => 'display: none;' ) );
210	210	}
211	211	$form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
212		- $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;submit_form( this );', 'type' => 'submit' ) );
	212	+ $form .= Xml::element( 'input', array( 'class' => 'button-plain', 'value' => wfMsg( 'payflowpro_gateway-donor-submit' ), 'onclick' => 'document.payment.PaypalRedirect.value=0;document.payment.submit();', 'type' => 'submit' ) );
213	213	$form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
214	214	$form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
215	215	wfMsg( 'payflowpro_gateway-donate-click' );
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnPayPal.php
—	—	@@ -31,7 +31,7 @@
32	32
33	33	// Xml::element seems to convert html to htmlentities
34	34	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
35		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );~~
	35	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
36	36
37	37	$form .= Xml::openElement( 'div', array( 'id' => 'left-column', 'class' => 'payflow-cc-form-section' ) );
38	38	$form .= $this->generatePersonalContainer();
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
—	—	@@ -58,7 +58,7 @@
59	59
60	60	// Xml::element seems to convert html to htmlentities
61	61	$form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
62		~~- $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );~~
	62	+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
63	63
64	64	$form .= $this->generateBillingContainer();
65	65	return $form;

Status & tagging log

22:49, 3 December 2010 Reedy (talk | contribs) changed the status of r76997 [removed: new added: deferred]