r76978 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76977‎ | r76978 | r76979 >
Date:22:17, 18 November 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Nitpick: switch array unique/values calls for clarity
Modified paths:
  • /trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
@@ -1043,14 +1043,14 @@
10441044 $defaultSummary = wfMsgExt( 'revreview-reject-default-summary-cur',
10451045 array( 'parsemag' ),
10461046 $wgLang->formatNum( count( $rejectIds ) ),
1047 - $wgLang->listToText( array_values( array_unique( $rejectIds ) ) ),
 1047+ $wgLang->listToText( array_unique( array_values( $rejectIds ) ) ),
10481048 $wgLang->timeanddate( $oldRev->getTimestamp(), true )
10491049 );
10501050 } else {
10511051 $defaultSummary = wfMsgExt( 'revreview-reject-default-summary-old',
10521052 array( 'parsemag' ),
10531053 $wgLang->formatNum( count( $rejectIds ) ),
1054 - $wgLang->listToText( array_values( array_unique( $rejectIds ) ) )
 1054+ $wgLang->listToText( array_unique( array_values( $rejectIds ) ) )
10551055 );
10561056 }
10571057

Follow-up revisions

RevisionCommit summaryAuthorDate
r77007Follow ups for r76962 and r75408:...aaron06:16, 19 November 2010

Comments

#Comment by Aaron Schulz (talk | contribs)   06:18, 19 November 2010

My mistake for suggesting this brain fart :)

Status & tagging log