r76970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76969‎ | r76970 | r76971 >
Date:21:54, 18 November 2010
Author:tparscal
Status:ok
Tags:
Comment:
Renamed mediawiki.views.* to mediawiki.action.* to better relate to the action= URL param
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.action (added) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js (added) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.views.history.js (deleted) (history)
  • /trunk/phase3/resources/mediawiki.views (deleted) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
@@ -86,7 +86,7 @@
8787 $wgOut->setRobotPolicy( 'noindex,nofollow' );
8888 $wgOut->setSyndicated( true );
8989 $wgOut->setFeedAppendQuery( 'action=history' );
90 - $wgOut->addModules( array( 'mediawiki.legacy.history', 'mediawiki.views.history' ) );
 90+ $wgOut->addModules( array( 'mediawiki.legacy.history', 'mediawiki.action.history' ) );
9191
9292 // Creation of a subtitle link pointing to [[Special:Log]]
9393 $logPage = SpecialPage::getTitleFor( 'Log' );
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js
@@ -0,0 +1,7 @@
 2+/*
 3+ * JavaScript for History action
 4+ */
 5+
 6+// Replaces histrowinit
 7+$( '#pagehistory li input[name=diff], #pagehistory li input[name=oldid]' ).click( diffcheck );
 8+diffcheck();
\ No newline at end of file
Property changes on: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js
___________________________________________________________________
Added: svn:eol-style
19 + native
Index: trunk/phase3/resources/Resources.php
@@ -344,8 +344,8 @@
345345 'mediawiki.specials.search' => new ResourceLoaderFileModule( array(
346346 'scripts' => 'resources/mediawiki.specials/mediawiki.specials.search.js',
347347 ) ),
348 - 'mediawiki.views.history' => new ResourceLoaderFileModule( array(
349 - 'scripts' => 'resources/mediawiki.views/mediawiki.views.history.js',
 348+ 'mediawiki.action.history' => new ResourceLoaderFileModule( array(
 349+ 'scripts' => 'resources/mediawiki.action/mediawiki.action.history.js',
350350 'dependencies' => 'mediawiki.legacy.history',
351351 ) ),
352352 'mediawiki.language' => new ResourceLoaderFileModule( array(

Status & tagging log