r76926 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76925‎ | r76926 | r76927 >
Date:00:15, 18 November 2010
Author:pdhanda
Status:resolved
Tags:
Comment:
Merged r76925 from branches/chad-pre-wmf-merge
Modified paths:
  • /trunk/extensions/FlaggedRevs (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
@@ -42,7 +42,7 @@
4343 'group-autoreview-member' => 'autochecked users',
4444 'grouppage-autoreview' => '{{ns:project}}:Autochecked users',
4545 'revcontents-error' => 'Unable to get content.',
46 - 'revcontents-getcontents' => '<a href="$1" >View this revision</a>',
 46+ 'revcontents-getcontents' => '[{{fullurl:$1|oldid=$2}} View this revision]',
4747 'revcontents-waiting' => 'Waiting for content',
4848 'revreview-hist-draft' => 'unchecked revision',
4949 'revreview-hist-pending' => 'pending revision',
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -1827,12 +1827,11 @@
18281828 * This will be replaced with artice content using javascript and an api call.
18291829 */
18301830 public function addCustomHtml( OutputPage $out ) {
1831 - global $wgTitle, $wgScript, $wgRequest;
 1831+ global $wgTitle;
18321832 $this->load();
1833 - if ( $wgRequest->getVal( 'oldid' ) ) {
1834 - $oldId = $wgRequest->getVal( 'oldid' );
1835 - $oldRevisionUrl = $wgScript . '?title=' . $wgTitle . '&oldid=' . $oldId;
1836 - $out->addHTML( "<div id='mw-fr-revisioncontents'>" . wfMsg( 'revcontents-getcontents', $oldRevisionUrl ) . "</div>" );
 1833+ if ( $out->getRevisionId() ) {
 1834+ $oldRevisionLink = wfMsgExt( 'revcontents-getcontents', array( 'parseinline' ), $wgTitle, $out->getRevisionId() );
 1835+ $out->addHTML( "<div id='mw-fr-revisioncontents' class='plainlinks'>" . $oldRevisionLink . "</div>" );
18371836 }
18381837
18391838 }
Property changes on: trunk/extensions/FlaggedRevs
___________________________________________________________________
Added: svn:mergeinfo
18401839 Merged /branches/chad-pre-wmf-merge/extensions/FlaggedRevs:r76925

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76925Fixed link in revcontents-getcontents from r76353. Fixed the same link to poi...pdhanda00:12, 18 November 2010

Status & tagging log