r76920 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r76919
|
r76920
|
r76921
>
Date:
23:36, 17 November 2010
Author:
reedy
Status:
ok
Tags:
Comment:
Fix minor refactoring bug from
r76905
, actually use values passed in
Modified paths:
/trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
—
—
@@ -68,7 +68,7 @@
69
69
if ( $this->mRev->isValidStatus( $status ) && $this->validPost( 'codereview-set-status' ) ) {
70
70
$statusChanged = $this->mRev->setStatus( $status, $wgUser );
71
71
}
72
- $addTags = $removeTags = array();
72
+ $validAddTags = $validRemoveTags = array();
73
73
if ( count( $addTags ) && $this->validPost( 'codereview-add-tag' ) ) {
74
74
$validAddTags = $addTags;
75
75
}
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r76905
Prequisite to
bug 25940
(Add API module(s) to add comments/set revision status)...
reedy
21:01, 17 November 2010
Status & tagging log
11:03, 3 December 2010
Catrope
(
talk
|
contribs
)
changed the
status
of r76920
[
removed:
new
added:
ok]