r76910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76909‎ | r76910 | r76911 >
Date:22:26, 17 November 2010
Author:reedy
Status:ok
Tags:
Comment:
No point overriding validPost in CodeRevisionCommitter, it's exactly the same as the one in SpecialCode, just in a slightly different order, and hence also doing duplicate things
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
——@@ -125,10 +125,4 @@
126126
127127 return $redirTarget;
128128 }
129 -
130 - public function validPost( $permission ) {
131 - global $wgUser, $wgRequest;
132 - return parent::validPost( $permission ) && $wgRequest->wasPosted()
133 - && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) );
134 - }
135129 }

Status & tagging log