r76878 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76877‎ | r76878 | r76879 >
Date:10:36, 17 November 2010
Author:aaron
Status:deferred
Tags:
Comment:
Follow-up r75331: we already have wgCurRevisionId, just use it
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/client/flaggedrevs.js (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -255,7 +255,7 @@
256256 $wgAvailableRights[] = 'stablesettings';
257257
258258 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
259 -$wgFlaggedRevStyleVersion = 80;
 259+$wgFlaggedRevStyleVersion = 81;
260260
261261 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
262262
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -110,7 +110,6 @@
111111 $stableId = null;
112112 }
113113 $globalVars['wgStableRevisionId'] = $stableId;
114 - $globalVars['wgLatestRevisionId'] = $fa->getLatest();
115114 $revisionContents = (object) array(
116115 'error' => wfMsgHtml( 'revcontents-error' ),
117116 'waiting' => wfMsgHtml( 'revcontents-waiting' )
Index: trunk/extensions/FlaggedRevs/client/flaggedrevs.js
@@ -194,7 +194,7 @@
195195 var origContents = contentsDiv.innerHTML;
196196 contentsDiv.innerHTML = "<span class='loading mw-small-spinner spinner'></span><span class='loading' >" + wgRevContents.waiting + "</span>";
197197 var requestArgs = 'action=parse&prop=text&format=xml';
198 - if ( window.wgLatestRevisionId == oldRevId && window.wgPageName ) {
 198+ if ( window.wgCurRevisionId == oldRevId && window.wgPageName ) {
199199 requestArgs += '&page=' + encodeURIComponent( window.wgPageName );
200200 } else {
201201 requestArgs += '&oldid=' + oldRevId;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75331bug25289 Changes to make revisions with pending changes not load content imme...pdhanda18:48, 24 October 2010

Status & tagging log