r76873 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76872‎ | r76873 | r76874 >
Date:03:05, 17 November 2010
Author:tomasz
Status:ok
Tags:
Comment:
Getting rid of collapsing css banners
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CentralNotice (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/CentralNotice/SpecialBannerController.php
@@ -139,18 +139,7 @@
140140 }
141141
142142 function getToggleScripts() {
143 - $showStyle = <<<HTML
144 -<style type="text/css">
145 -#centralNotice .siteNoticeSmall {display:none;}
146 -#centralNotice.collapsed .siteNoticeBig {display:none;}
147 -#centralNotice.collapsed .siteNoticeSmall {display:block;}
148 -</style>
149 -HTML;
150 - $encShowStyle = Xml::encodeJsVar( $showStyle );
151 -
152 - $script = "
153 -var wgNoticeToggleState = (document.cookie.indexOf('hidesnmessage=1')==-1);
154 -document.writeln($encShowStyle);\n\n";
 143+ $script = "var wgNoticeToggleState = (document.cookie.indexOf('hidesnmessage=1')==-1);\n\n";
155144 return $script;
156145 }
157146
Property changes on: branches/wmf/1.16wmf4/extensions/CentralNotice
___________________________________________________________________
Modified: svn:mergeinfo
158147 Merged /trunk/extensions/CentralNotice:r76763

Status & tagging log